packaging
/
ostree
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

rofiles-fuse: Improve error message for failure to open root 

I was debugging some rpm-ostree work and saw:
`openat: No such file or directory`
and it wasn't immediately obvious it was stderr from `rofiles-fuse`.

Use the `err` API which is better in many ways; in this case
it automatically prefixes with `argv0`.

Closes: #1747
Approved by: jlebon
This commit is contained in:
Colin Walters 2018-10-02 11:47:48 -04:00 committed by Atomic Bot
parent 43d9cac4fc
commit 04aff9c1c0
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/rofiles-fuse/main.c
View File

@ -25,6 +25,7 @@
#include <sys/stat.h> #include <sys/stat.h>
#include <sys/statvfs.h> #include <sys/statvfs.h>
#include <stdio.h> #include <stdio.h>
#include <err.h>
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
#include <errno.h> #include <errno.h>
@ -628,10 +629,7 @@ rofs_parse_opt (void *data, const char *arg, int key,
{ {
basefd = openat (AT_FDCWD, arg, O_RDONLY | O_NONBLOCK | O_DIRECTORY | O_CLOEXEC | O_NOCTTY); basefd = openat (AT_FDCWD, arg, O_RDONLY | O_NONBLOCK | O_DIRECTORY | O_CLOEXEC | O_NOCTTY);
if (basefd == -1) if (basefd == -1)
{ err (1, "opening rootfs %s", arg);
perror ("openat");
exit (EXIT_FAILURE);
}
return 0; return 0;
} }
else else