From 0b214566a244df2da1fcd2db09b5560a9b3d7280 Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Sun, 12 Mar 2017 21:11:41 -0400 Subject: [PATCH] lib: Squash most of the gtk-doc warnings for missing parameters This isn't all of them, just trying to make a dent. Closes: #734 Approved by: jlebon --- src/libostree/ostree-repo.c | 7 +++++++ src/libostree/ostree-sepolicy.c | 3 +++ src/libostree/ostree-sysroot-upgrader.c | 14 ++++++++++++++ src/libostree/ostree-sysroot.c | 3 ++- 4 files changed, 26 insertions(+), 1 deletion(-) diff --git a/src/libostree/ostree-repo.c b/src/libostree/ostree-repo.c index 0f1c3631..34da969f 100644 --- a/src/libostree/ostree-repo.c +++ b/src/libostree/ostree-repo.c @@ -4226,6 +4226,13 @@ out: /** * ostree_repo_sign_delta: + * @self: Self + * @from_commit: From commit + * @to_commit: To commit + * @key_id: key id + * @homedir: homedir + * @cancellable: cancellable + * @error: error * * This function is deprecated, sign the summary file instead. * Add a GPG signature to a static delta. diff --git a/src/libostree/ostree-sepolicy.c b/src/libostree/ostree-sepolicy.c index fa264704..716cbd8c 100644 --- a/src/libostree/ostree-sepolicy.c +++ b/src/libostree/ostree-sepolicy.c @@ -378,6 +378,8 @@ initable_iface_init (GInitableIface *initable_iface) /** * ostree_sepolicy_new: * @path: Path to a root directory + * @cancellable: Cancellable + * @error: Error * * Returns: (transfer full): An accessor object for SELinux policy in root located at @path */ @@ -621,6 +623,7 @@ ostree_sepolicy_setfscreatecon (OstreeSePolicy *self, /** * ostree_sepolicy_fscreatecon_cleanup: + * @unused: Not used, just in case you didn't infer that from the parameter name * * Cleanup function for ostree_sepolicy_setfscreatecon(). */ diff --git a/src/libostree/ostree-sysroot-upgrader.c b/src/libostree/ostree-sysroot-upgrader.c index 232f8435..4e7c8bf3 100644 --- a/src/libostree/ostree-sysroot-upgrader.c +++ b/src/libostree/ostree-sysroot-upgrader.c @@ -293,6 +293,8 @@ ostree_sysroot_upgrader_init (OstreeSysrootUpgrader *self) /** * ostree_sysroot_upgrader_new: * @sysroot: An #OstreeSysroot + * @cancellable: Cancellable + * @error: Error * * Returns: (transfer full): An upgrader */ @@ -309,6 +311,8 @@ ostree_sysroot_upgrader_new (OstreeSysroot *sysroot, * ostree_sysroot_upgrader_new_for_os: * @sysroot: An #OstreeSysroot * @osname: (allow-none): Operating system name + * @cancellable: Cancellable + * @error: Error * * Returns: (transfer full): An upgrader */ @@ -327,6 +331,8 @@ ostree_sysroot_upgrader_new_for_os (OstreeSysroot *sysroot, * @sysroot: An #OstreeSysroot * @osname: (allow-none): Operating system name * @flags: Flags + * @cancellable: Cancellable + * @error: Error * * Returns: (transfer full): An upgrader */ @@ -514,6 +520,14 @@ ostree_sysroot_upgrader_pull (OstreeSysrootUpgrader *self, /** * ostree_sysroot_upgrader_pull_one_dir: + * @self: Upgrader + * @dir_to_pull: Subdirectory path (should include a leading /) + * @flags: Flags controlling pull behavior + * @upgrader_flags: Flags controlling upgrader behavior + * @progress: (allow-none): Progress + * @out_changed: (out): Whether or not the origin changed + * @cancellable: Cancellable + * @error: Error * * Like ostree_sysroot_upgrader_pull(), but allows retrieving just a * subpath of the tree. This can be used to download metadata files diff --git a/src/libostree/ostree-sysroot.c b/src/libostree/ostree-sysroot.c index 4ed0d759..238ee74a 100644 --- a/src/libostree/ostree-sysroot.c +++ b/src/libostree/ostree-sysroot.c @@ -1269,12 +1269,13 @@ ostree_sysroot_get_merge_deployment (OstreeSysroot *self, /** * ostree_sysroot_origin_new_from_refspec: + * @self: Sysroot * @refspec: A refspec * * Returns: (transfer full): A new config file which sets @refspec as an origin */ GKeyFile * -ostree_sysroot_origin_new_from_refspec (OstreeSysroot *sysroot, +ostree_sysroot_origin_new_from_refspec (OstreeSysroot *self, const char *refspec) { GKeyFile *ret = g_key_file_new ();