From 0c2ea54e68937e460b15428d14972cedf9070856 Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Sat, 7 Sep 2013 21:56:36 -0400 Subject: [PATCH] core: Make ostree_set_xattrs() private Nothing external uses it. We keep ostree_get_xattrs_for_file() public because it's convenient for external consumers to get xattrs in exactly the format we desire. https://bugzilla.gnome.org/show_bug.cgi?id=707733 --- src/libostree/ostree-core-private.h | 4 ++++ src/libostree/ostree-core.c | 12 ++++++------ src/libostree/ostree-core.h | 3 --- src/libostree/ostree-repo-checkout.c | 2 +- src/libostree/ostree-repo-commit.c | 2 +- 5 files changed, 12 insertions(+), 11 deletions(-) diff --git a/src/libostree/ostree-core-private.h b/src/libostree/ostree-core-private.h index 3fe67f9c..b564c215 100644 --- a/src/libostree/ostree-core-private.h +++ b/src/libostree/ostree-core-private.h @@ -80,6 +80,10 @@ _ostree_set_xattrs_fd (int fd, GCancellable *cancellable, GError **error); +gboolean _ostree_set_xattrs (GFile *f, GVariant *xattrs, + GCancellable *cancellable, GError **error); + + /* XX + / + checksum-2 + . + extension, but let's just use 256 for a * bit of overkill. */ diff --git a/src/libostree/ostree-core.c b/src/libostree/ostree-core.c index 185aa82d..f43f58ae 100644 --- a/src/libostree/ostree-core.c +++ b/src/libostree/ostree-core.c @@ -1073,8 +1073,8 @@ _ostree_set_xattrs_fd (int fd, return ret; } -/** - * ostree_set_xattrs: +/* + * _ostree_set_xattrs: * @f: a file * @xattrs: Extended attribute list * @cancellable: Cancellable @@ -1085,10 +1085,10 @@ _ostree_set_xattrs_fd (int fd, * attributes. */ gboolean -ostree_set_xattrs (GFile *f, - GVariant *xattrs, - GCancellable *cancellable, - GError **error) +_ostree_set_xattrs (GFile *f, + GVariant *xattrs, + GCancellable *cancellable, + GError **error) { const char *path; gboolean ret = FALSE; diff --git a/src/libostree/ostree-core.h b/src/libostree/ostree-core.h index 2a0a8564..743ca8f1 100644 --- a/src/libostree/ostree-core.h +++ b/src/libostree/ostree-core.h @@ -176,9 +176,6 @@ gboolean ostree_get_xattrs_for_file (GFile *f, GCancellable *cancellable, GError **error); -gboolean ostree_set_xattrs (GFile *f, GVariant *xattrs, - GCancellable *cancellable, GError **error); - gboolean ostree_content_stream_parse (gboolean compressed, GInputStream *input, diff --git a/src/libostree/ostree-repo-checkout.c b/src/libostree/ostree-repo-checkout.c index 83ed9110..d307db5a 100644 --- a/src/libostree/ostree-repo-checkout.c +++ b/src/libostree/ostree-repo-checkout.c @@ -217,7 +217,7 @@ create_file_from_input (GFile *dest_file, if (xattrs != NULL) { - if (!ostree_set_xattrs (dest_file, xattrs, cancellable, error)) + if (!_ostree_set_xattrs (dest_file, xattrs, cancellable, error)) goto out; } diff --git a/src/libostree/ostree-repo-commit.c b/src/libostree/ostree-repo-commit.c index 1a49b753..d983cd20 100644 --- a/src/libostree/ostree-repo-commit.c +++ b/src/libostree/ostree-repo-commit.c @@ -91,7 +91,7 @@ commit_loose_object_trusted (OstreeRepo *self, */ if (xattrs != NULL) { - if (!ostree_set_xattrs (temp_file, xattrs, cancellable, error)) + if (!_ostree_set_xattrs (temp_file, xattrs, cancellable, error)) goto out; } }