packaging
/
ostree
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lib/repo-finder: Avoid a potential unref-of-NULL crash 

As the comment explains, it’s possible for a result to be freed while
ref_to_checksum is NULL, even though normally the data structure
guarantees it’s non-NULL. This was causing crashes when results were
filtered out of a find-remotes call. Guard against that.

Signed-off-by: Philip Withnall <withnall@endlessm.com>

Closes: #1058
Approved by: cgwalters
This commit is contained in:
Philip Withnall 2017-08-07 19:49:17 +01:00 committed by Atomic Bot
parent be4832242d
commit 0d2a9a7909
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/libostree/ostree-repo-finder.c
View File

@ -550,7 +550,9 @@ ostree_repo_finder_result_free (OstreeRepoFinderResult *result)
{ {
g_return_if_fail (result != NULL); g_return_if_fail (result != NULL);
g_hash_table_unref (result->ref_to_checksum); /* This may be NULL iff the result is freed half-way through find_remotes_cb()
* in ostree-repo-pull.c, and at no other time. */
g_clear_pointer (&result->ref_to_checksum, g_hash_table_unref);
g_object_unref (result->finder); g_object_unref (result->finder);
ostree_remote_unref (result->remote); ostree_remote_unref (result->remote);
g_free (result); g_free (result);