From 0ded552cf1440a806bd7af684b63f486c03d67c9 Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Thu, 20 Jul 2017 15:34:15 -0400 Subject: [PATCH] ci: Enable -Werror for clang I hit an unused-variable warning with `GLNX_AUTO_PREFIX_ERROR` for rpm-ostree and led me to wonder why ostree didn't fail, then I noticed we had lost the special `-Werror=unused-variable` bit. Let's go ahead and use `-Werror` for clang too. Closes: #1023 Approved by: jlebon --- .papr.yml | 1 + ci/build-check.sh | 3 +++ 2 files changed, 4 insertions(+) diff --git a/.papr.yml b/.papr.yml index 4ec0765c..ea378c98 100644 --- a/.papr.yml +++ b/.papr.yml @@ -31,6 +31,7 @@ timeout: 30m artifacts: - test-suite.log + - config.log --- context: c7-primary diff --git a/ci/build-check.sh b/ci/build-check.sh index 0e12000f..7df1f424 100755 --- a/ci/build-check.sh +++ b/ci/build-check.sh @@ -15,6 +15,9 @@ if test -x /usr/bin/gnome-desktop-testing-runner; then fi if test -x /usr/bin/clang; then + # always fail on warnings; https://github.com/ostreedev/ostree/pull/971 + # Except for clang-4.0: error: argument unused during compilation: '-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1' [-Werror,-Wunused-command-line-argument] + export CFLAGS="-Wno-error=unused-command-line-argument -Werror ${CFLAGS:-}" git clean -dfx && git submodule foreach git clean -dfx # And now a clang build to find unused variables because it does a better # job than gcc for vars with cleanups; perhaps in the future these could