From 10c2fc33f68fbc7d8b9d29888d76cc0b44a170be Mon Sep 17 00:00:00 2001 From: Robert Fairley Date: Thu, 5 Jul 2018 14:59:24 -0400 Subject: [PATCH] tests: Run network retries test for many retries directly This runs a test involving many retries for the --network-retries option directly rather than inside a conditional statement, so that the command does not silently fail and allow the test to continue running. Closes: #1673 Approved by: jlebon --- tests/test-pull-repeated.sh | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/test-pull-repeated.sh b/tests/test-pull-repeated.sh index 306d48e5..a2707d6d 100755 --- a/tests/test-pull-repeated.sh +++ b/tests/test-pull-repeated.sh @@ -90,9 +90,8 @@ ostree_repo_init repo --mode=archive ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin $(cat httpd-address)/ostree/gnomerepo # Using 8 network retries gives error rate of <0.5%, when --random-408s=50 -if ${CMD_PREFIX} ostree --repo=repo pull --mirror origin --network-retries=8 main 2>err.txt; then - echo "Success with big number of network retries" -fi +${CMD_PREFIX} ostree --repo=repo pull --mirror origin --network-retries=8 main +echo "Success with big number of network retries" ${CMD_PREFIX} ostree --repo=repo fsck ${CMD_PREFIX} ostree --repo=repo rev-parse main