packaging
/
ostree
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lib/commit: Update docs/code style for ostree_repo_scan_hardlinks() 

Happened to notice this one `goto out` user, and decided to tweak the docs at
the same time.

Closes: #1144
Approved by: jlebon
This commit is contained in:
Colin Walters 2017-09-06 17:11:27 -04:00 committed by Atomic Bot
parent 303320163f
commit 11179e30bd
1 changed files with 12 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/libostree/ostree-repo-commit.c
View File

@ -1029,35 +1029,33 @@ devino_cache_lookup (OstreeRepo *self,
* @cancellable: Cancellable * @cancellable: Cancellable
* @error: Error * @error: Error
* *
* When ostree builds a mutable tree from directory like in * This function is deprecated in favor of using ostree_repo_devino_cache_new(),
* ostree_repo_write_directory_to_mtree(), it has to scan all files that you * which allows a precise mapping to be built up between hardlink checkout files
* pass in and compute their checksums. If your commit contains hardlinks from * and their checksums between `ostree_repo_checkout_at()` and
* ostree's existing repo, ostree can build a mapping of device numbers and * `ostree_repo_write_directory_to_mtree()`.
* inodes to their checksum. *
* When invoking ostree_repo_write_directory_to_mtree(), it has to compute the
* checksum of all files. If your commit contains hardlinks from a checkout,
* this functions builds a mapping of device numbers and inodes to their
* checksum.
* *
* There is an upfront cost to creating this mapping, as this will scan the * There is an upfront cost to creating this mapping, as this will scan the
* entire objects directory. If your commit is composed of mostly hardlinks to * entire objects directory. If your commit is composed of mostly hardlinks to
* existing ostree objects, then this will speed up considerably, so call it * existing ostree objects, then this will speed up considerably, so call it
* before you call ostree_write_directory_to_mtree() or similar. * before you call ostree_write_directory_to_mtree() or similar. However,
* ostree_repo_devino_cache_new() is better as it avoids scanning all objects.
*/ */
gboolean gboolean
ostree_repo_scan_hardlinks (OstreeRepo *self, ostree_repo_scan_hardlinks (OstreeRepo *self,
GCancellable *cancellable, GCancellable *cancellable,
GError **error) GError **error)
{ {
gboolean ret = FALSE;
g_return_val_if_fail (self->in_transaction == TRUE, FALSE); g_return_val_if_fail (self->in_transaction == TRUE, FALSE);
if (!self->loose_object_devino_hash) if (!self->loose_object_devino_hash)
self->loose_object_devino_hash = (GHashTable*)ostree_repo_devino_cache_new (); self->loose_object_devino_hash = (GHashTable*)ostree_repo_devino_cache_new ();
g_hash_table_remove_all (self->loose_object_devino_hash); g_hash_table_remove_all (self->loose_object_devino_hash);
if (!scan_loose_devino (self, self->loose_object_devino_hash, cancellable, error)) return scan_loose_devino (self, self->loose_object_devino_hash, cancellable, error);
goto out;
ret = TRUE;
out:
return ret;
} }
/** /**