From 11fdca291950771858872386560e1103df1dda5f Mon Sep 17 00:00:00 2001 From: Jonathan Lebon Date: Mon, 21 Aug 2017 16:52:59 -0400 Subject: [PATCH] pull: better description for --mirror Describe the behaviour of --mirror a bit better. Closes: #1100 Closes: #1099 Approved by: dustymabe --- man/ostree-pull.xml | 7 ++++++- src/libostree/ostree-repo.h | 2 +- src/ostree/ot-builtin-pull.c | 2 +- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/man/ostree-pull.xml b/man/ostree-pull.xml index 59a6dbc8..9c970714 100644 --- a/man/ostree-pull.xml +++ b/man/ostree-pull.xml @@ -103,7 +103,12 @@ Boston, MA 02111-1307, USA. - Write refs suitable for a mirror. + Write refs suitable for a mirror, i.e. refs are stored in the + heads/ directory rather than the + remotes/ directory. This makes the target repo + suitable to be exported for other clients to pull from as an ostree + remote. If no specific refs are specified, all refs will be fetched (the + remote must have a summary file present). diff --git a/src/libostree/ostree-repo.h b/src/libostree/ostree-repo.h index 8766e6df..ab1aa0b3 100644 --- a/src/libostree/ostree-repo.h +++ b/src/libostree/ostree-repo.h @@ -1081,7 +1081,7 @@ gboolean ostree_repo_prune_from_reachable (OstreeRepo *self, /** * OstreeRepoPullFlags: * @OSTREE_REPO_PULL_FLAGS_NONE: No special options for pull - * @OSTREE_REPO_PULL_FLAGS_MIRROR: Write out refs suitable for mirrors + * @OSTREE_REPO_PULL_FLAGS_MIRROR: Write out refs suitable for mirrors and fetch all refs if none requested * @OSTREE_REPO_PULL_FLAGS_COMMIT_ONLY: Fetch only the commit metadata * @OSTREE_REPO_PULL_FLAGS_UNTRUSTED: Don't trust local remote * @OSTREE_REPO_PULL_FLAGS_BAREUSERONLY_FILES: Since 2017.7. Reject writes of content objects with modes outside of 0775. diff --git a/src/ostree/ot-builtin-pull.c b/src/ostree/ot-builtin-pull.c index eceddb0f..ebcde49d 100644 --- a/src/ostree/ot-builtin-pull.c +++ b/src/ostree/ot-builtin-pull.c @@ -55,7 +55,7 @@ static GOptionEntry options[] = { { "disable-fsync", 0, 0, G_OPTION_ARG_NONE, &opt_disable_fsync, "Do not invoke fsync()", NULL }, { "disable-static-deltas", 0, 0, G_OPTION_ARG_NONE, &opt_disable_static_deltas, "Do not use static deltas", NULL }, { "require-static-deltas", 0, 0, G_OPTION_ARG_NONE, &opt_require_static_deltas, "Require static deltas", NULL }, - { "mirror", 0, 0, G_OPTION_ARG_NONE, &opt_mirror, "Write refs suitable for a mirror", NULL }, + { "mirror", 0, 0, G_OPTION_ARG_NONE, &opt_mirror, "Write refs suitable for a mirror and fetches all refs if none provided", NULL }, { "subpath", 0, 0, G_OPTION_ARG_FILENAME_ARRAY, &opt_subpaths, "Only pull the provided subpath(s)", NULL }, { "untrusted", 0, 0, G_OPTION_ARG_NONE, &opt_untrusted, "Do not trust (local) sources", NULL }, { "bareuseronly-files", 0, 0, G_OPTION_ARG_NONE, &opt_bareuseronly_files, "Reject regular files with mode outside of 0775 (world writable, suid, etc.)", NULL },