From 18b85fa8bdb2e1b794a3f3ecc56d618c88744f92 Mon Sep 17 00:00:00 2001 From: Jonathan Lebon Date: Wed, 18 Oct 2017 13:33:58 +0000 Subject: [PATCH] lib/commit: fix checking flag with bitwise OR Caught by Coverity. Coverity CID: 1458339 Closes: #1290 Approved by: cgwalters --- src/libostree/ostree-repo-commit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libostree/ostree-repo-commit.c b/src/libostree/ostree-repo-commit.c index eb5f92a4..b6fbd3d1 100644 --- a/src/libostree/ostree-repo-commit.c +++ b/src/libostree/ostree-repo-commit.c @@ -2835,7 +2835,7 @@ write_directory_content_to_mtree_internal (OstreeRepo *self, file_type == G_FILE_TYPE_REGULAR && dfd_iter != NULL && delete_after_commit - && (writeflags | WRITE_DIR_CONTENT_FLAGS_CAN_ADOPT) > 0; + && ((writeflags & WRITE_DIR_CONTENT_FLAGS_CAN_ADOPT) > 0); gboolean can_adopt = can_adopt_basic; /* If basic prerquisites are met, check repo mode specific ones */ if (can_adopt)