packaging
/
ostree
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sign-dummy: optimize ostree_sign_dummy_data_verify 

Return TRUE as soon as any signature verified.

Signed-off-by: Denis Pynkin <denis.pynkin@collabora.com>
This commit is contained in:
Denis Pynkin 2020-02-18 00:46:51 +03:00
parent aaf73f6afc
commit 1e3bdef285
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/libostree/ostree-sign-dummy.c
View File

@ -156,7 +156,6 @@ gboolean ostree_sign_dummy_data_verify (OstreeSign *self,
if (!g_variant_is_of_type (signatures, (GVariantType *) OSTREE_SIGN_METADATA_DUMMY_TYPE)) if (!g_variant_is_of_type (signatures, (GVariantType *) OSTREE_SIGN_METADATA_DUMMY_TYPE))
return glnx_throw (error, "signature: dummy: wrong type passed for verification"); return glnx_throw (error, "signature: dummy: wrong type passed for verification");
gboolean verified = FALSE;
for (gsize i = 0; i < g_variant_n_children(signatures); i++) for (gsize i = 0; i < g_variant_n_children(signatures); i++)
{ {
g_autoptr (GVariant) child = g_variant_get_child_value (signatures, i); g_autoptr (GVariant) child = g_variant_get_child_value (signatures, i);
@ -169,12 +168,10 @@ gboolean ostree_sign_dummy_data_verify (OstreeSign *self,
g_debug("Stored signature %d: %s", (gint)i, sign->pk_ascii); g_debug("Stored signature %d: %s", (gint)i, sign->pk_ascii);
if (!g_strcmp0(sign_ascii, sign->pk_ascii)) if (!g_strcmp0(sign_ascii, sign->pk_ascii))
verified = TRUE; return TRUE;
else else
return glnx_throw (error, "signature: dummy: incorrect signature %" G_GSIZE_FORMAT, i); return glnx_throw (error, "signature: dummy: incorrect signature %" G_GSIZE_FORMAT, i);
} }
if (!verified)
return glnx_throw (error, "signature: dummy: no signatures");
return TRUE; return glnx_throw (error, "signature: dummy: no signatures");
} }