diff --git a/.cci.jenkinsfile b/.cci.jenkinsfile index 213d23c9..2a64109a 100644 --- a/.cci.jenkinsfile +++ b/.cci.jenkinsfile @@ -3,7 +3,7 @@ stage("Build") { parallel normal: { def n = 5 - buildPod(runAsUser:0, memory: "2Gi", cpu: "${n}") { + buildPod(memory: "2Gi", cpu: "${n}") { checkout scm stage("Core build") { shwrap(""" @@ -39,7 +39,7 @@ parallel normal: { }, // A minimal build, helps test our build options minimal: { - buildPod(runAsUser:0) { + buildPod() { checkout scm shwrap(""" git submodule update --init @@ -54,7 +54,7 @@ minimal: { } }, codestyle: { - buildPod(runAsUser:0) { + buildPod() { checkout scm shwrap(""" # Jenkins by default only fetches the branch it's testing. Explicitly fetch main diff --git a/ci/build.sh b/ci/build.sh index ffdeba01..2afcd018 100755 --- a/ci/build.sh +++ b/ci/build.sh @@ -30,6 +30,6 @@ esac # always fail on warnings; https://github.com/ostreedev/ostree/pull/971 # NB: this disables the default set of flags from configure.ac -export CFLAGS="-Wall -Werror -fanalyzer ${CFLAGS:-}" +export CFLAGS="-Wall -Werror ${CFLAGS:-}" build --enable-gtk-doc ${CONFIGOPTS:-} diff --git a/src/libostree/ostree-sysroot.c b/src/libostree/ostree-sysroot.c index 67afb5d2..bcb55e55 100644 --- a/src/libostree/ostree-sysroot.c +++ b/src/libostree/ostree-sysroot.c @@ -1267,7 +1267,7 @@ ostree_sysroot_get_booted_deployment (OstreeSysroot *self) OstreeDeployment * ostree_sysroot_require_booted_deployment (OstreeSysroot *self, GError **error) { - g_return_val_if_fail (self->loadstate == OSTREE_SYSROOT_LOAD_STATE_LOADED, NULL); + g_assert (self->loadstate == OSTREE_SYSROOT_LOAD_STATE_LOADED); if (!self->booted_deployment) return glnx_null_throw (error, "Not currently booted into an OSTree system"); @@ -1286,7 +1286,7 @@ ostree_sysroot_require_booted_deployment (OstreeSysroot *self, GError **error) OstreeDeployment * ostree_sysroot_get_staged_deployment (OstreeSysroot *self) { - g_return_val_if_fail (self->loadstate == OSTREE_SYSROOT_LOAD_STATE_LOADED, NULL); + g_assert (self->loadstate == OSTREE_SYSROOT_LOAD_STATE_LOADED); return self->staged_deployment; } @@ -1300,7 +1300,7 @@ ostree_sysroot_get_staged_deployment (OstreeSysroot *self) GPtrArray * ostree_sysroot_get_deployments (OstreeSysroot *self) { - g_return_val_if_fail (self->loadstate == OSTREE_SYSROOT_LOAD_STATE_LOADED, NULL); + g_assert (self->loadstate == OSTREE_SYSROOT_LOAD_STATE_LOADED); GPtrArray *copy = g_ptr_array_new_with_free_func ((GDestroyNotify)g_object_unref); for (guint i = 0; i < self->deployments->len; i++) @@ -1525,7 +1525,7 @@ ostree_sysroot_query_deployments_for (OstreeSysroot *self, OstreeDeployment **out_pending, OstreeDeployment **out_rollback) { - g_return_if_fail (osname != NULL || self->booted_deployment != NULL); + g_assert (osname != NULL || self->booted_deployment != NULL); g_autoptr(OstreeDeployment) ret_pending = NULL; g_autoptr(OstreeDeployment) ret_rollback = NULL; @@ -1896,6 +1896,7 @@ ostree_sysroot_simple_write_deployment (OstreeSysroot *sysroot, /* tracks when we come across the booted deployment */ gboolean before_booted = TRUE; gboolean before_merge = TRUE; + g_assert (deployments); for (guint i = 0; i < deployments->len; i++) { OstreeDeployment *deployment = deployments->pdata[i];