From 213d5013cec6abe61c3500c1bffceff1a42d5509 Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Sun, 30 Oct 2016 14:12:02 +0000 Subject: [PATCH] ostree_builtin_pull: consistently set free-function on refs_to_fetch We are relying on the GPtrArray to free its contents, but we only give it a free-function on one code path. Found by valgrind memcheck. Signed-off-by: Simon McVittie Closes: #559 Approved by: cgwalters --- src/ostree/ot-builtin-pull.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ostree/ot-builtin-pull.c b/src/ostree/ot-builtin-pull.c index 9f48c2e0..52a55375 100644 --- a/src/ostree/ot-builtin-pull.c +++ b/src/ostree/ot-builtin-pull.c @@ -198,7 +198,7 @@ ostree_builtin_pull (int argc, char **argv, GCancellable *cancellable, GError ** else { char *ref_to_fetch; - refs_to_fetch = g_ptr_array_new (); + refs_to_fetch = g_ptr_array_new_with_free_func (g_free); if (!ostree_parse_refspec (argv[1], &remote, &ref_to_fetch, error)) goto out; /* Transfer ownership */