packaging
/
ostree
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

delta: Unreference files we've processed 

This should help avoid address space exhaustion on 32 bit systems,
and in general is obviously going to improve efficiency.

Closes: #498
Approved by: alexlarsson
This commit is contained in:
Colin Walters 2016-09-08 10:47:33 -04:00 committed by Atomic Bot
parent e127070550
commit 23b4b58d57
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/libostree/ostree-repo-static-delta-compilation.c
View File

@ -429,8 +429,8 @@ content_rollsums_free (ContentRollsum *rollsum)
{ {
g_free (rollsum->from_checksum); g_free (rollsum->from_checksum);
_ostree_rollsum_matches_free (rollsum->matches); _ostree_rollsum_matches_free (rollsum->matches);
g_bytes_unref (rollsum->tmp_from); g_clear_pointer (&rollsum->tmp_from, g_bytes_unref);
g_bytes_unref (rollsum->tmp_to); g_clear_pointer (&rollsum->tmp_to, g_bytes_unref);
g_free (rollsum); g_free (rollsum);
} }
@ -438,8 +438,8 @@ static void
content_bsdiffs_free (ContentBsdiff *bsdiff) content_bsdiffs_free (ContentBsdiff *bsdiff)
{ {
g_free (bsdiff->from_checksum); g_free (bsdiff->from_checksum);
g_bytes_unref (bsdiff->tmp_from); g_clear_pointer (&bsdiff->tmp_from, g_bytes_unref);
g_bytes_unref (bsdiff->tmp_to); g_clear_pointer (&bsdiff->tmp_to, g_bytes_unref);
g_free (bsdiff); g_free (bsdiff);
} }
@ -758,6 +758,9 @@ process_one_rollsum (OstreeRepo *repo,
g_string_append_c (current_part->operations, (gchar)OSTREE_STATIC_DELTA_OP_CLOSE); g_string_append_c (current_part->operations, (gchar)OSTREE_STATIC_DELTA_OP_CLOSE);
} }
g_clear_pointer (&rollsum->tmp_from, g_bytes_unref);
g_clear_pointer (&rollsum->tmp_to, g_bytes_unref);
ret = TRUE; ret = TRUE;
out: out:
return ret; return ret;
@ -854,6 +857,9 @@ process_one_bsdiff (OstreeRepo *repo,
g_string_append_c (current_part->operations, (gchar)OSTREE_STATIC_DELTA_OP_UNSET_READ_SOURCE); g_string_append_c (current_part->operations, (gchar)OSTREE_STATIC_DELTA_OP_UNSET_READ_SOURCE);
g_clear_pointer (&bsdiff_content->tmp_from, g_bytes_unref);
g_clear_pointer (&bsdiff_content->tmp_to, g_bytes_unref);
ret = TRUE; ret = TRUE;
out: out:
return ret; return ret;