From 2f2af9252db84b2a0c91324788722c4335411c8b Mon Sep 17 00:00:00 2001 From: Krzesimir Nowak Date: Tue, 24 May 2016 10:36:38 +0200 Subject: [PATCH] libotutil: Plug a leak There's no need to allocate the variant builder on a heap, so allocate it on the stack and avoid a memory leak at the same time. Closes: #307 Approved by: cgwalters --- src/libotutil/ot-variant-utils.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/libotutil/ot-variant-utils.c b/src/libotutil/ot-variant-utils.c index 2dc07582..7b54542e 100644 --- a/src/libotutil/ot-variant-utils.c +++ b/src/libotutil/ot-variant-utils.c @@ -33,7 +33,10 @@ GVariant * ot_gvariant_new_empty_string_dict (void) { - return g_variant_builder_end (g_variant_builder_new (G_VARIANT_TYPE ("a{sv}"))); + g_auto(GVariantBuilder) builder = {{0,}}; + + g_variant_builder_init (&builder, G_VARIANT_TYPE ("a{sv}")); + return g_variant_builder_end (&builder); } GVariant *