From 36ab8cd0e1cf487fe5f03917a617ab88d7b0a86d Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Mon, 31 Jul 2017 09:27:56 -0400 Subject: [PATCH] tests: Add some return value checking to pacify Coverity No real problems here, but Coverity likes to see consistent checking of return values, and I agree with it. Coverity CID: 1452213 Coverity CID: 1452211 Closes: #1037 Approved by: jlebon --- src/ostree/ostree-trivial-httpd.c | 2 +- tests/test-bsdiff.c | 2 +- tests/test-mutable-tree.c | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/ostree/ostree-trivial-httpd.c b/src/ostree/ostree-trivial-httpd.c index 176f5ec7..de04e9a4 100644 --- a/src/ostree/ostree-trivial-httpd.c +++ b/src/ostree/ostree-trivial-httpd.c @@ -94,7 +94,7 @@ httpd_log (OtTrivialHttpd *httpd, const gchar *format, ...) g_string_append_vprintf (str, format, args); va_end (args); - g_output_stream_write_all (httpd->log, str->str, str->len, &written, NULL, NULL); + (void)g_output_stream_write_all (httpd->log, str->str, str->len, &written, NULL, NULL); } static int diff --git a/tests/test-bsdiff.c b/tests/test-bsdiff.c index 24772a1e..0bf500da 100644 --- a/tests/test-bsdiff.c +++ b/tests/test-bsdiff.c @@ -86,7 +86,7 @@ test_bsdiff (void) bsdiff_stream.opaque = out; g_assert_cmpint (bsdiff (old, OLD_SIZE, new, NEW_SIZE, &bsdiff_stream), ==, 0); - g_output_stream_close (out, NULL, NULL); + g_assert (g_output_stream_close (out, NULL, NULL)); /* Now generate NEW_GENERATED from OLD and OUT. */ { g_autoptr(GBytes) bytes = g_memory_output_stream_steal_as_bytes (G_MEMORY_OUTPUT_STREAM (out)); diff --git a/tests/test-mutable-tree.c b/tests/test-mutable-tree.c index 9df36ac6..f878f116 100644 --- a/tests/test-mutable-tree.c +++ b/tests/test-mutable-tree.c @@ -72,8 +72,10 @@ test_mutable_tree_walk (void) glnx_unref_object OstreeMutableTree *subdir = NULL; glnx_unref_object OstreeMutableTree *a = NULL; g_autofree char *source_checksum = NULL; - ostree_mutable_tree_lookup (tree, "a", &source_checksum, &a, &error); + g_assert (ostree_mutable_tree_lookup (tree, "a", &source_checksum, &a, &error)); + g_assert_no_error (error); g_assert (ostree_mutable_tree_walk (a, split_path, 1, &subdir, &error)); + g_assert_no_error (error); g_assert (subdir); } }