From 3767ac4ad83d0d0c720d68603f65bfd9a0ebb006 Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Thu, 21 Sep 2017 11:00:09 -0400 Subject: [PATCH] lib/repo: Move alloca() outside of loop Just noticed this while looking at the code for a different issue. Closes: #1201 Approved by: jlebon --- src/libostree/ostree-repo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libostree/ostree-repo.c b/src/libostree/ostree-repo.c index 0056d805..e04a1b6a 100644 --- a/src/libostree/ostree-repo.c +++ b/src/libostree/ostree-repo.c @@ -5179,11 +5179,11 @@ _ostree_repo_allocate_tmpdir (int tmpdir_dfd, ret_tmpdir.initialized = TRUE; } + const char *tmpdir_name_template = glnx_strjoina (tmpdir_prefix, "XXXXXX"); while (!ret_tmpdir.initialized) { g_auto(GLnxTmpDir) new_tmpdir = { 0, }; /* No existing tmpdir found, create a new */ - const char *tmpdir_name_template = glnx_strjoina (tmpdir_prefix, "XXXXXX"); if (!glnx_mkdtempat (tmpdir_dfd, tmpdir_name_template, 0755, &new_tmpdir, error)) return FALSE;