From 3e3d28632d9a3c9cd974531487bdc830c326b184 Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Mon, 9 Oct 2017 10:05:20 -0400 Subject: [PATCH] lib/commit: Make -path commit helper API private It's no longer called directly by the pull code, so make it static. The goal here is to have the pull and local-fs commit paths use higher level more efficient APIs, and eventually make those APIs public. Closes: #1257 Approved by: jlebon --- src/libostree/ostree-repo-commit.c | 19 +++++++++---------- src/libostree/ostree-repo-private.h | 8 -------- 2 files changed, 9 insertions(+), 18 deletions(-) diff --git a/src/libostree/ostree-repo-commit.c b/src/libostree/ostree-repo-commit.c index ad9bc5af..d045fd3f 100644 --- a/src/libostree/ostree-repo-commit.c +++ b/src/libostree/ostree-repo-commit.c @@ -164,13 +164,13 @@ _ostree_repo_commit_tmpf_final (OstreeRepo *self, /* Given a dfd+path combination (may be regular file or symlink), * rename it into place. */ -gboolean -_ostree_repo_commit_path_final (OstreeRepo *self, - const char *checksum, - OstreeObjectType objtype, - OtCleanupUnlinkat *tmp_path, - GCancellable *cancellable, - GError **error) +static gboolean +commit_path_final (OstreeRepo *self, + const char *checksum, + OstreeObjectType objtype, + OtCleanupUnlinkat *tmp_path, + GCancellable *cancellable, + GError **error) { /* The final renameat() */ char tmpbuf[_OSTREE_LOOSE_PATH_MAX]; @@ -746,9 +746,8 @@ write_content_object (OstreeRepo *self, g_assert_not_reached (); } - if (!_ostree_repo_commit_path_final (self, actual_checksum, OSTREE_OBJECT_TYPE_FILE, - &tmp_unlinker, - cancellable, error)) + if (!commit_path_final (self, actual_checksum, OSTREE_OBJECT_TYPE_FILE, + &tmp_unlinker, cancellable, error)) return FALSE; } else diff --git a/src/libostree/ostree-repo-private.h b/src/libostree/ostree-repo-private.h index 7d50a5b7..bbbb700e 100644 --- a/src/libostree/ostree-repo-private.h +++ b/src/libostree/ostree-repo-private.h @@ -365,14 +365,6 @@ _ostree_repo_commit_tmpf_final (OstreeRepo *self, GCancellable *cancellable, GError **error); -gboolean -_ostree_repo_commit_path_final (OstreeRepo *self, - const char *checksum, - OstreeObjectType objtype, - OtCleanupUnlinkat *tmp_path, - GCancellable *cancellable, - GError **error); - gboolean _ostree_repo_open_content_bare (OstreeRepo *self, const char *checksum,