pull: Update key loading function to match error style
This code wasn't written with idiomatic GError usage; it's not standard to construct an error up front and continually append to its message. The exit from a function is usually `return TRUE`, with error conditions before that. Updating it to match style reveals what I think is a bug; we were silently ignoring failure to parse key files.
This commit is contained in:
1 parent
a16fe86b36
commit
47539874b8
2 files changed
+8
-16
No files matched your search
@@ -93,6 +93,7 @@ echo "ok pull failure with incorrect keys file option"
|
||||
|
||||
# Test with correct dummy key
|
||||
${CMD_PREFIX} ostree --repo=repo config set 'remote "origin"'.verification-key "${DUMMYSIGN}"
|
||||
${CMD_PREFIX} ostree --repo=repo config unset 'remote "origin"'.verification-file
|
||||
test_signed_pull "dummy" ""
|
||||
|
||||
if ! has_libsodium; then
|
||||
|
||||
Reference in new issue
Block a user