Fix up triggers and gnomeos-make-image.sh

Now both do something.

Makefile-triggers.am

@@ -16,8 +16,8 @@
 # along with this program; if not, write to the Free Software
 # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
 
-triggersdir = $(datadir)/ostree/triggers.d
+triggersdir = $(libexecdir)/ostree/triggers.d
-triggers_DATA = \
+triggers_SCRIPTS = \
 	triggers.d/desktop-database.trigger \
 	triggers.d/gdk-pixbuf.trigger \
 	triggers.d/glib.trigger \

Makefile.am

@@ -1,5 +1,5 @@
 ACLOCAL_AMFLAGS = -I m4 ${ACLOCAL_FLAGS}
-AM_CPPFLAGS = -DDATADIR='"$(datadir)"'
+AM_CPPFLAGS = -DDATADIR='"$(datadir)"' -DLIBEXECDIR='"$(libexecdir)"'
 
 NULL = 
 BUILT_SOURCES =

parallel-debian/gnomeos-make-image.sh

@@ -32,30 +32,34 @@ case `uname -p` in
 esac;
 
 DEBTARGET=wheezy
-KERNELPKG=linux-image-3.0.0-1-amd64
 
 NOTSHARED_DIRS="dev bin etc lib lib32 lib64 proc media mnt run sbin selinux sys srv usr"
-SHARED_DIRS="home root opt tmp var"
+SHARED_DIRS="home root tmp var"
+
+if ! test -d debootstrap-$DEBTARGET; then
+    echo "Creating $DEBTARGET.img"
+    mkdir -p debootstrap-$DEBTARGET.tmp
+    debootstrap --download-only --arch $ARCH $DEBTARGET debootstrap-$DEBTARGET.tmp
+    mv debootstrap-$DEBTARGET.tmp debootstrap-$DEBTARGET
+fi
 
 if ! test -f $DEBTARGET.img; then
     echo "Creating $DEBTARGET.img"
-    mkdir -p debootstrap-$DEBTARGET
+    umount fs || true
-    debootstrap --download-only --arch $ARCH $DEBTARGET debootstrap-$DEBTARGET
+    mkdir -p fs
-    
-    umount gnomeos-fs-$DEBTARGET || true
-    mkdir -p gnomeos-fs-$DEBTARGET
     qemu-img create $DEBTARGET.img.tmp 2G
-    mkfs.ext2 -q -F $DEBTARGET.img.tmp
+    mkfs.ext4 -q -F $DEBTARGET.img.tmp
-    mount -o loop $DEBTARGET.img.tmp gnomeos-fs-$DEBTARGET
+    mount -o loop $DEBTARGET.img.tmp fs
 
     for d in debootstrap-$DEBTARGET/var/cache/apt/archives/*.deb; do
-        tmpdir=`mktemp -d`
+        tmpdir=`mktemp --tmpdir=. -d`
-        (cd tmpdir;
+        (cd ${tmpdir};
             ar x ../$d;
-            tar -x -z -C ../gnomeos-fs-$DEBTARGET -f data.tar.gz)
+            tar -x -z -C ../fs -f data.tar.gz)
+        rm -rf ${tmpdir}
     done
 
-    umount gnomeos-fs-$DEBTARGET
+    umount fs
     mv $DEBTARGET.img.tmp $DEBTARGET.img
 fi
 
@@ -65,9 +69,10 @@ fi
 if ! test -f gnomeos.img; then
     echo "Cloning gnomeos.img from $DEBTARGET.img"
     cp -a --sparse=always $DEBTARGET.img gnomeos.img.tmp
-    umount gnomeos-fs || true
+    mkdir -p fs
-    mount -o loop gnomeos.img.tmp gnomeos-fs
+    umount fs || true
-    (cd gnomeos-fs;
+    mount -o loop gnomeos.img.tmp fs
+    (cd fs;
         mkdir ostree
         mkdir ostree/repo
         mkdir ostree/gnomeos-origin
@@ -89,7 +94,7 @@ if ! test -f gnomeos.img; then
             ostree checkout --repo=repo HEAD gnomeos-${rev}
             ln -s gnomeos-${rev} current)
     )
-    umount gnomeos-fs
+    umount fs
     mv gnomeos.img.tmp gnomeos.img
 fi
 

src/libostree/ostree-checkout.c

@@ -194,6 +194,8 @@ run_trigger (OstreeCheckout *self,
 
   path = g_file_get_path (trigger);
   basename = g_path_get_basename (path);
+
+  args = g_ptr_array_new ();
   
   if (requires_chroot)
     {
@@ -291,7 +293,7 @@ ostree_checkout_run_triggers (OstreeCheckout *self,
   GFileInfo *file_info = NULL;
   GFileEnumerator *enumerator = NULL;
 
-  triggerdir_path = g_build_filename (DATADIR, "ostree", "triggers.d", NULL);
+  triggerdir_path = g_build_filename (LIBEXECDIR, "ostree", "triggers.d", NULL);
   triggerdir = ot_util_new_file_for_path (triggerdir_path);
 
   enumerator = g_file_enumerate_children (triggerdir, "standard::name,standard::type,unix::*",