From 549f1ec7df58b9e9adcd25a0825f47fc71d2dd9e Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Wed, 21 Jan 2015 21:16:11 -0500 Subject: [PATCH] commit: Fix segfault on async writes if object exists and checksum requested If an object already existed and we somehow tried to pull it, the caller would still expect a returned checksum. This appears to happen with static deltas for some reason; we might be including duplicate metadata objects. Regardless, this is a bug that should be fixed. --- src/libostree/ostree-repo-commit.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libostree/ostree-repo-commit.c b/src/libostree/ostree-repo-commit.c index ca52704e..a149c2e0 100644 --- a/src/libostree/ostree-repo-commit.c +++ b/src/libostree/ostree-repo-commit.c @@ -478,6 +478,8 @@ write_object (OstreeRepo *self, goto out; if (have_obj) { + if (out_csum) + *out_csum = ostree_checksum_to_bytes (expected_checksum); ret = TRUE; goto out; }