sign: fix memory leaks and code cleanup
Return `const char *` instead of copy of the string -- this allow to avoid unneeded copying and memory leaks in some constructions. Minor code cleanup and optimisations. Signed-off-by: Denis Pynkin <denis.pynkin@collabora.com>
This commit is contained in:
1 parent
5fc2ddff30
commit
557f423609
7 files changed
+65
-85
No files matched your search
@@ -108,30 +108,26 @@ gboolean ostree_sign_dummy_data (OstreeSign *self,
|
||||
return TRUE;
|
||||
}
|
||||
|
||||
gchar * ostree_sign_dummy_get_name (OstreeSign *self)
|
||||
const gchar * ostree_sign_dummy_get_name (OstreeSign *self)
|
||||
{
|
||||
g_debug ("%s enter", __FUNCTION__);
|
||||
g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE);
|
||||
|
||||
g_autofree gchar *name = g_strdup(OSTREE_SIGN_DUMMY_NAME);
|
||||
|
||||
return g_steal_pointer (&name);
|
||||
return OSTREE_SIGN_DUMMY_NAME;
|
||||
}
|
||||
|
||||
gchar * ostree_sign_dummy_metadata_key (OstreeSign *self)
|
||||
const gchar * ostree_sign_dummy_metadata_key (OstreeSign *self)
|
||||
{
|
||||
g_debug ("%s enter", __FUNCTION__);
|
||||
|
||||
g_autofree gchar *key = g_strdup(OSTREE_SIGN_METADATA_DUMMY_KEY);
|
||||
return g_steal_pointer (&key);
|
||||
return OSTREE_SIGN_METADATA_DUMMY_KEY;
|
||||
}
|
||||
|
||||
gchar * ostree_sign_dummy_metadata_format (OstreeSign *self)
|
||||
const gchar * ostree_sign_dummy_metadata_format (OstreeSign *self)
|
||||
{
|
||||
g_debug ("%s enter", __FUNCTION__);
|
||||
|
||||
g_autofree gchar *type = g_strdup(OSTREE_SIGN_METADATA_DUMMY_TYPE);
|
||||
return g_steal_pointer (&type);
|
||||
return OSTREE_SIGN_METADATA_DUMMY_TYPE;
|
||||
}
|
||||
|
||||
gboolean ostree_sign_dummy_metadata_verify (OstreeSign *self,
|
||||
|
||||
Reference in new issue
Block a user