packaging/ostree
1
0 Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sign: fix memory leaks and code cleanup

Browse Source 
Return `const char *` instead of copy of the string -- this allow to
avoid unneeded copying and memory leaks in some constructions.
Minor code cleanup and optimisations.

Signed-off-by: Denis Pynkin <denis.pynkin@collabora.com>
This commit is contained in:
Denis Pynkin committed 2020-03-25 15:23:54 +03:00
1 parent 5fc2ddff30
commit 557f423609
7 files changed
+65 -85
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/libostree/ostree-sign.h
+5 -5
View File
@@ -47,14 +47,14 @@ G_DECLARE_INTERFACE (OstreeSign, ostree_sign, OSTREE, SIGN, GObject)
struct _OstreeSignInterface
{
GTypeInterface g_iface;
gchar *(* get_name) (OstreeSign *self);
const gchar *(* get_name) (OstreeSign *self);
gboolean (* data) (OstreeSign *self,
GBytes *data,
GBytes **signature,
GCancellable *cancellable,
GError **error);
gchar *(* metadata_key) (OstreeSign *self);
gchar *(* metadata_format) (OstreeSign *self);
const gchar *(* metadata_key) (OstreeSign *self);
const gchar *(* metadata_format) (OstreeSign *self);
gboolean (* metadata_verify) (OstreeSign *self,
GBytes *data,
GVariant *metadata,
@@ -90,10 +90,10 @@ gboolean ostree_sign_data (OstreeSign *self,
_OSTREE_PUBLIC
gchar * ostree_sign_metadata_key (OstreeSign *self);
const gchar * ostree_sign_metadata_key (OstreeSign *self);
_OSTREE_PUBLIC
gchar * ostree_sign_metadata_format (OstreeSign *self);
const gchar * ostree_sign_metadata_format (OstreeSign *self);
_OSTREE_PUBLIC
GVariant * ostree_sign_detached_metadata_append (OstreeSign *self,