packaging
/
ostree
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ci: Enable -Werror=unused-result with -Wp,-D_FORTIFY_SOURCE=2 

(Also rename the other CI contexts to be more consistent)

We pass this right now. I just noticed an instance of this in bwrap, and I think
we should be trying to match the RPM build baseline.

Closes: #765
Approved by: jlebon
This commit is contained in:
Colin Walters 2017-03-28 13:29:38 -04:00 committed by Atomic Bot
parent a88881039e
commit 562cb55f51
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
.redhat-ci.yml
View File

@ -4,6 +4,7 @@ branches:
- try - try
required: true required: true
context: f25-sanitizer
container: container:
image: projectatomic/ostree-tester image: projectatomic/ostree-tester
@ -12,7 +13,7 @@ packages:
- libasan - libasan
env: env:
CFLAGS: '-fsanitize=undefined -fsanitize-undefined-trap-on-error -fsanitize=address' CFLAGS: '-fsanitize=undefined -fsanitize-undefined-trap-on-error -fsanitize=address -O2 -Wp,-D_FORTIFY_SOURCE=2'
ASAN_OPTIONS: 'detect_leaks=0' # Right now we're not fully clean, but this gets us use-after-free etc ASAN_OPTIONS: 'detect_leaks=0' # Right now we're not fully clean, but this gets us use-after-free etc
# TODO when we're doing leak checks: G_SLICE: "always-malloc" # TODO when we're doing leak checks: G_SLICE: "always-malloc"
@ -38,7 +39,7 @@ artifacts:
inherit: true inherit: true
required: true required: true
context: Clang context: f25-clang
env: env:
CC: 'clang' CC: 'clang'
@ -76,7 +77,7 @@ tests:
inherit: true inherit: true
required: true required: true
context: curl-openssl context: f25-curl-openssl
packages: packages:
- pkgconfig(libcurl) - pkgconfig(libcurl)

1
configure.ac
View File

@ -42,6 +42,7 @@ CC_CHECK_FLAGS_APPEND([WARN_CFLAGS], [CFLAGS], [\
-Werror=incompatible-pointer-types \ -Werror=incompatible-pointer-types \
-Werror=misleading-indentation \ -Werror=misleading-indentation \
-Werror=missing-include-dirs -Werror=aggregate-return \ -Werror=missing-include-dirs -Werror=aggregate-return \
-Werror=unused-result \
]) ])
AC_SUBST(WARN_CFLAGS) AC_SUBST(WARN_CFLAGS)