From 57270db9a1c75daa4ec11ab9f1bb41609c29214b Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Tue, 30 Mar 2021 20:51:51 +0000 Subject: [PATCH] repo: Ensure load_variant_if_exists sets NULL value Spotted by @jlebon - we usually expect callers to zero, but let's be explicit. --- src/libostree/ostree-repo.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/libostree/ostree-repo.c b/src/libostree/ostree-repo.c index 40841c7b..b2347b47 100644 --- a/src/libostree/ostree-repo.c +++ b/src/libostree/ostree-repo.c @@ -3686,6 +3686,10 @@ load_metadata_internal (OstreeRepo *self, g_return_val_if_fail (OSTREE_OBJECT_TYPE_IS_META (objtype), FALSE); g_return_val_if_fail (objtype == OSTREE_OBJECT_TYPE_COMMIT || out_state == NULL, FALSE); + /* Ensure this is set to NULL if we didn't find the object */ + if (out_variant) + *out_variant = NULL; + /* Special caching for dirmeta objects, since they're commonly referenced many * times. */