From 58532e591731ef5b613c59906e5df1c4ffc7ad69 Mon Sep 17 00:00:00 2001 From: Krzesimir Nowak Date: Mon, 9 May 2016 15:11:18 +0200 Subject: [PATCH] sysroot: Plug some leaks The deployments and booted deployment were never unreffed. Also, remote (void) from the call to the unload function - it returns nothing, so there is no need to fool the compiler. Closes: #287 Approved by: cgwalters --- src/libostree/ostree-sysroot.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/libostree/ostree-sysroot.c b/src/libostree/ostree-sysroot.c index b114a901..e05f5c29 100644 --- a/src/libostree/ostree-sysroot.c +++ b/src/libostree/ostree-sysroot.c @@ -70,10 +70,12 @@ ostree_sysroot_finalize (GObject *object) g_clear_object (&self->path); g_clear_object (&self->sepolicy); g_clear_object (&self->repo); + g_clear_pointer (&self->deployments, g_ptr_array_unref); + g_clear_object (&self->booted_deployment); glnx_release_lock_file (&self->lock); - (void) ostree_sysroot_unload (self); + ostree_sysroot_unload (self); G_OBJECT_CLASS (ostree_sysroot_parent_class)->finalize (object); } @@ -873,7 +875,7 @@ ostree_sysroot_load_if_changed (OstreeSysroot *self, } g_clear_pointer (&self->deployments, g_ptr_array_unref); - g_clear_pointer (&self->booted_deployment, g_object_unref); + g_clear_object (&self->booted_deployment); self->bootversion = -1; self->subbootversion = -1;