From 66da1199f0e6bff78b94d54b619c1bc2eed009c6 Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Mon, 5 Dec 2016 13:08:39 -0500 Subject: [PATCH] tests/keyfile-utils: Drop tests covering preconditions The spam in stderr was bothering me, and further at some eventual point in the future we want to annotate the functions with `__attribute__((nonnull))` which would then cause tests like these to become undefined behavior. The coverage of this isn't worth the log spam basically. Closes: #611 Approved by: jlebon --- tests/test-keyfile-utils.c | 31 ------------------------------- 1 file changed, 31 deletions(-) diff --git a/tests/test-keyfile-utils.c b/tests/test-keyfile-utils.c index 8fd59163..376b0e82 100644 --- a/tests/test-keyfile-utils.c +++ b/tests/test-keyfile-utils.c @@ -34,37 +34,6 @@ test_get_boolean_with_default (void) g_autoptr(GError) error = NULL; gboolean out = FALSE; - GLogLevelFlags always_fatal_mask; - - /* Avoid that g_return_val_if_fail causes the test to fail. */ - always_fatal_mask = g_log_set_always_fatal (0); - - - g_assert_false (ot_keyfile_get_boolean_with_default (NULL, - "section", - "a_boolean_true", - FALSE, - &out, - &error)); - g_clear_error (&error); - g_assert_false (ot_keyfile_get_boolean_with_default (g_keyfile, - NULL, - "a_boolean_true", - FALSE, - &out, - &error)); - g_clear_error (&error); - g_assert_false (ot_keyfile_get_boolean_with_default (g_keyfile, - "section", - NULL, - FALSE, - &out, - &error)); - g_clear_error (&error); - - /* Restore the old mask. */ - g_log_set_always_fatal (always_fatal_mask); - g_assert (ot_keyfile_get_boolean_with_default (g_keyfile, "section", "a_boolean_true",