From 6eac1085601db797661ca18e05f9235c3f742de7 Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Sat, 21 Jun 2014 12:11:56 -0400 Subject: [PATCH] remote: Minor argument parsing cleanup Only access relevant portion of argv after we've verified argc. https://bugzilla.gnome.org/show_bug.cgi?id=731984 --- src/ostree/ot-builtin-remote.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/ostree/ot-builtin-remote.c b/src/ostree/ot-builtin-remote.c index 75abc559..3a9c3b74 100644 --- a/src/ostree/ot-builtin-remote.c +++ b/src/ostree/ot-builtin-remote.c @@ -98,7 +98,7 @@ ostree_builtin_remote (int argc, char **argv, OstreeRepo *repo, GCancellable *ca if (!strcmp (op, "add")) { - const char *url = argv[3]; + const char *url; char **iter; gs_free char *target_name = NULL; gs_unref_object GFile *target_conf = NULL; @@ -110,6 +110,8 @@ ostree_builtin_remote (int argc, char **argv, OstreeRepo *repo, GCancellable *ca goto out; } + url = argv[3]; + optbuilder = g_variant_builder_new (G_VARIANT_TYPE ("a{sv}")); if (argc > 4)