packaging
/
ostree
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

repo: Fix file descriptor leak from previous commit 

I keep forgetting mmap doesn't take ownership of the fd.
This commit is contained in:
Colin Walters 2013-09-08 10:41:18 -04:00
parent 5a685ff989
commit 75225166da
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/libostree/ostree-repo.c
View File

@ -827,7 +827,8 @@ load_metadata_internal (OstreeRepo *self,
mfile = g_mapped_file_new_from_fd (fd, FALSE, error); mfile = g_mapped_file_new_from_fd (fd, FALSE, error);
if (!mfile) if (!mfile)
goto out; goto out;
fd = -1; /* Transfer ownership */ (void) close (fd); /* Ignore errors, we have it mapped */
fd = -1;
ret_variant = g_variant_new_from_data (ostree_metadata_variant_type (objtype), ret_variant = g_variant_new_from_data (ostree_metadata_variant_type (objtype),
g_mapped_file_get_contents (mfile), g_mapped_file_get_contents (mfile),
g_mapped_file_get_length (mfile), g_mapped_file_get_length (mfile),