diff --git a/src/libostree/ostree-core.c b/src/libostree/ostree-core.c index d7da3497..147d0f3c 100644 --- a/src/libostree/ostree-core.c +++ b/src/libostree/ostree-core.c @@ -203,8 +203,7 @@ checksum_directory (GFile *f, *out_checksum = ret_checksum; ret_checksum = NULL; out: - if (ret_checksum) - g_checksum_free (ret_checksum); + ot_clear_checksum (&ret_checksum); ot_clear_gvariant (&dirmeta); ot_clear_gvariant (&packed); return ret; @@ -304,8 +303,7 @@ checksum_nondirectory (GFile *f, g_clear_object (&input); g_free (basename); ot_clear_gvariant (&xattrs); - if (content_sha256) - g_checksum_free (content_sha256); + ot_clear_checksum (&content_sha256); return ret; } @@ -376,8 +374,7 @@ checksum_file_async_data_free (gpointer datap) ChecksumFileAsyncData *data = datap; g_object_unref (data->f); - if (data->checksum) - g_checksum_free (data->checksum); + ot_clear_checksum (&data->checksum); g_free (data); } @@ -774,8 +771,7 @@ unpack_meta (GFile *file, *out_checksum = ret_checksum; ret_checksum = NULL; out: - if (ret_checksum) - g_checksum_free (ret_checksum); + ot_clear_checksum (&ret_checksum); g_clear_object (&in); return ret; } @@ -970,8 +966,7 @@ unpack_file (GFile *file, out: if (!ret) (void) unlink (dest_path); - if (ret_checksum) - g_checksum_free (ret_checksum); + ot_clear_checksum (&ret_checksum); g_clear_object (&in); g_clear_object (&out); ot_clear_gvariant (&metadata); diff --git a/src/libostree/ostree-repo.c b/src/libostree/ostree-repo.c index 337b61c1..1ba63244 100644 --- a/src/libostree/ostree-repo.c +++ b/src/libostree/ostree-repo.c @@ -626,8 +626,7 @@ write_gvariant_to_tmp (OstreeRepo *self, g_free (tmp_name); if (fd != -1) close (fd); - if (checksum) - g_checksum_free (checksum); + ot_clear_checksum (&checksum); ot_clear_gvariant (&serialized); g_free (dest_name); g_clear_object (&stream); @@ -661,8 +660,7 @@ import_gvariant_object (OstreeRepo *self, out: (void) g_file_delete (tmp_path, NULL, NULL); g_clear_object (&tmp_path); - if (ret_checksum) - g_checksum_free (ret_checksum); + ot_clear_checksum (&ret_checksum); return ret; } @@ -734,8 +732,7 @@ import_directory_meta (OstreeRepo *self, } out: g_clear_object (&f_info); - if (ret_checksum) - g_checksum_free (ret_checksum); + ot_clear_checksum (&ret_checksum); ot_clear_gvariant (&dirmeta); return ret; } @@ -948,8 +945,7 @@ ostree_repo_store_packfile (OstreeRepo *self, (void) g_file_delete (tempfile, NULL, NULL); g_clear_object (&tempfile); g_clear_object (&src); - if (checksum) - g_checksum_free (checksum); + ot_clear_checksum (&checksum); return ret; } @@ -1035,8 +1031,7 @@ import_commit (OstreeRepo *self, ret_commit = NULL; } out: - if (ret_commit) - g_checksum_free (ret_commit); + ot_clear_checksum (&ret_commit); ot_clear_gvariant (&commit); if (now) g_date_time_unref (now); @@ -1099,8 +1094,8 @@ import_directory_recurse (OstreeRepo *self, if (g_file_info_get_file_type (child_info) == G_FILE_TYPE_DIRECTORY) { - GChecksum *child_dir_metadata_checksum; - GChecksum *child_dir_contents_checksum; + GChecksum *child_dir_metadata_checksum = NULL; + GChecksum *child_dir_contents_checksum = NULL; if (!import_directory_recurse (self, base, child, &child_dir_contents_checksum, &child_dir_metadata_checksum, cancellable, error)) @@ -1110,13 +1105,12 @@ import_directory_recurse (OstreeRepo *self, g_strdup (g_checksum_get_string (child_dir_contents_checksum))); g_hash_table_replace (dir_metadata_checksums, g_strdup (name), g_strdup (g_checksum_get_string (child_dir_metadata_checksum))); - g_checksum_free (child_dir_contents_checksum); - g_checksum_free (child_dir_metadata_checksum); + ot_clear_checksum (&child_dir_contents_checksum); + ot_clear_checksum (&child_dir_metadata_checksum); } else { - if (child_file_checksum) - g_checksum_free (child_file_checksum); + ot_clear_checksum (&child_file_checksum); if (!ostree_checksum_file (child, OSTREE_OBJECT_TYPE_FILE, &child_file_checksum, cancellable, error)) goto out; @@ -1206,12 +1200,9 @@ import_directory_recurse (OstreeRepo *self, g_hash_table_destroy (file_checksums); g_hash_table_destroy (dir_metadata_checksums); g_hash_table_destroy (dir_contents_checksums); - if (ret_metadata_checksum) - g_checksum_free (ret_metadata_checksum); - if (ret_contents_checksum) - g_checksum_free (ret_contents_checksum); - if (child_file_checksum) - g_checksum_free (child_file_checksum); + ot_clear_checksum (&ret_metadata_checksum); + ot_clear_checksum (&ret_contents_checksum); + ot_clear_checksum (&child_file_checksum); g_slist_free (sorted_filenames); if (builders_initialized) { @@ -1264,13 +1255,10 @@ ostree_repo_commit (OstreeRepo *self, *out_commit = ret_commit_checksum; ret_commit_checksum = NULL; out: - if (ret_commit_checksum) - g_checksum_free (ret_commit_checksum); + ot_clear_checksum (&ret_commit_checksum); g_free (current_head); - if (root_metadata_checksum) - g_checksum_free (root_metadata_checksum); - if (root_contents_checksum) - g_checksum_free (root_contents_checksum); + ot_clear_checksum (&root_metadata_checksum); + ot_clear_checksum (&root_contents_checksum); return ret; } @@ -1645,8 +1633,7 @@ get_file_checksum (GFile *f, *out_checksum = ret_checksum; ret_checksum = NULL; out: - if (tmp_checksum) - g_checksum_free (tmp_checksum); + ot_clear_checksum (&tmp_checksum); return ret; } diff --git a/src/ostree/ot-builtin-checksum.c b/src/ostree/ot-builtin-checksum.c index 0eb5a032..48511339 100644 --- a/src/ostree/ot-builtin-checksum.c +++ b/src/ostree/ot-builtin-checksum.c @@ -48,7 +48,7 @@ on_checksum_received (GObject *obj, { g_print ("%s\n", g_checksum_get_string (checksum)); - g_checksum_free (checksum); + ot_clear_checksum (&checksum); } g_main_loop_quit (data->loop); diff --git a/src/ostree/ot-builtin-commit.c b/src/ostree/ot-builtin-commit.c index 73b9e6b2..3c064a07 100644 --- a/src/ostree/ot-builtin-commit.c +++ b/src/ostree/ot-builtin-commit.c @@ -138,7 +138,6 @@ ostree_builtin_commit (int argc, char **argv, const char *repo_path, GError **er if (context) g_option_context_free (context); g_clear_object (&repo); - if (commit_checksum) - g_checksum_free (commit_checksum); + ot_clear_checksum (&commit_checksum); return ret; } diff --git a/src/ostree/ot-builtin-fsck.c b/src/ostree/ot-builtin-fsck.c index 1cbd93e0..f1936448 100644 --- a/src/ostree/ot-builtin-fsck.c +++ b/src/ostree/ot-builtin-fsck.c @@ -99,8 +99,7 @@ checksum_packed_file (OtFsckData *data, *out_checksum = ret_checksum; ret_checksum = NULL; out: - if (ret_checksum) - g_checksum_free (ret_checksum); + ot_clear_checksum (&ret_checksum); g_free (metadata_buf); g_clear_object (&in); ot_clear_gvariant (&metadata); @@ -156,8 +155,7 @@ object_iter_callback (OstreeRepo *repo, data->n_objects++; out: - if (real_checksum != NULL) - g_checksum_free (real_checksum); + ot_clear_checksum (&real_checksum); if (error != NULL) { g_printerr ("%s\n", error->message);