tree-wide: Add+run spatch to use glnx_throw()

I had to run a sed job to add whitespace after, but otherwise this was easy.

Closes: #890
Approved by: jlebon

coccinelle/new-error.cocci

@@ -0,0 +1,19 @@
+// Conversion for G_IO_ERROR_FAILED that could be glnx_throw()
+@@
+expression p;
+@@
+- g_set_error_literal (error, G_IO_ERROR, G_IO_ERROR_FAILED, p);
+- return FALSE;
++ return glnx_throw (error, "%s", p);
+@@
+expression p;
+@@
+- g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED, p);
+- return FALSE;
++ return glnx_throw (error, p);
+@@
+expression p, q;
+@@
+- g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED, p, q);
+- return FALSE;
++ return glnx_throw (error, p, q);

src/libostree/ostree-core.c

@@ -1763,16 +1763,12 @@ validate_variant (GVariant           *variant,
 {
   if (!g_variant_is_normal_form (variant))
     {
-      g_set_error_literal (error, G_IO_ERROR, G_IO_ERROR_FAILED,
+      return glnx_throw (error, "%s", "Not normal form");
-                           "Not normal form");
-      return FALSE;
     }
   if (!g_variant_is_of_type (variant, variant_type))
     {
-      g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED,
+      return glnx_throw (error, "Doesn't match variant type '%s'",
-                   "Doesn't match variant type '%s'",
+                        (char *)variant_type);
-                   (char*)variant_type);
-      return FALSE;
     }
   return TRUE;
 }

src/libostree/ostree-gpg-verify-result.c

@@ -665,9 +665,8 @@ ostree_gpg_verify_result_require_valid_signature (OstreeGpgVerifyResult *result,
 
   if (ostree_gpg_verify_result_count_valid (result) == 0)
     {
-      g_set_error_literal (error, G_IO_ERROR, G_IO_ERROR_FAILED,
+      return glnx_throw (error, "%s",
-                           "GPG signatures found, but none are in trusted keyring");
+                        "GPG signatures found, but none are in trusted keyring");
-      return FALSE;
     }
 
   return TRUE;

src/libostree/ostree-repo-libarchive.c

@@ -640,9 +640,8 @@ aic_handle_entry (OstreeRepoArchiveImportContext *ctx,
         return TRUE;
       else
         {
-          g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED,
+          return glnx_throw (error, "Unsupported file type for path \"%s\"",
-                       "Unsupported file type for path \"%s\"", path);
+                            path);
-          return FALSE;
         }
     }
 }

src/libostree/ostree-repo-static-delta-core.c

@@ -45,9 +45,8 @@ _ostree_static_delta_parse_checksum_array (GVariant      *array,
   if (G_UNLIKELY(n > (G_MAXUINT32/OSTREE_STATIC_DELTA_OBJTYPE_CSUM_LEN) ||
                  (n_checksums * OSTREE_STATIC_DELTA_OBJTYPE_CSUM_LEN) != n))
     {
-      g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED,
+      return glnx_throw (error,
-                   "Invalid checksum array length %" G_GSIZE_FORMAT, n);
+                        "Invalid checksum array length %" G_GSIZE_FORMAT, n);
-      return FALSE;
     }
 
   *out_checksums_array = (gpointer)g_variant_get_data (array);

src/libostree/ostree-repo-static-delta-processing.c

@@ -115,9 +115,7 @@ read_varuint64 (StaticDeltaExecutionState  *state,
   gsize bytes_read;
   if (!_ostree_read_varuint64 (state->opdata, state->oplen, out_value, &bytes_read))
     {
-      g_set_error_literal (error, G_IO_ERROR, G_IO_ERROR_FAILED,
+      return glnx_throw (error, "%s", "Unexpected EOF reading varint");
-                           "Unexpected EOF reading varint");
-      return FALSE;
     }
   state->opdata += bytes_read;
   state->oplen -= bytes_read;

src/libostree/ostree-sysroot-deploy.c

@@ -1028,9 +1028,9 @@ checksum_from_kernel_src (const char   *name,
   const char *last_dash = strrchr (name, '-');
   if (!last_dash)
     {
-      g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED,
+      return glnx_throw (error,
-                   "Malformed kernel/initramfs name '%s', missing '-'", name);
+                        "Malformed kernel/initramfs name '%s', missing '-'",
-      return FALSE;
+                        name);
     }
   *out_checksum = g_strdup (last_dash + 1);
   return TRUE;

src/libotutil/ot-tool-util.c

@@ -40,9 +40,7 @@ ot_parse_boolean (const char  *value,
     *out_parsed = FALSE;
   else
     {
-      g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED,
+      return glnx_throw (error, "Invalid boolean argument '%s'", value);
-                   "Invalid boolean argument '%s'", value);
-      return FALSE;
     }
 
   return TRUE;
@@ -57,9 +55,7 @@ ot_parse_keyvalue (const char  *keyvalue,
   const char *eq = strchr (keyvalue, '=');
   if (!eq)
     {
-      g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED,
+      return glnx_throw (error, "Missing '=' in KEY=VALUE for --set");
-                   "Missing '=' in KEY=VALUE for --set");
-      return FALSE;
     }
   *out_key = g_strndup (keyvalue, eq - keyvalue);
   *out_value = g_strdup (eq + 1);

src/libotutil/ot-unix-utils.c

@@ -41,21 +41,15 @@ ot_util_filename_validate (const char *name,
 {
   if (strcmp (name, ".") == 0)
     {
-      g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED,
+      return glnx_throw (error, "Invalid self-referential filename '.'");
-                   "Invalid self-referential filename '.'");
-      return FALSE;
     }
   if (strcmp (name, "..") == 0)
     {
-      g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED,
+      return glnx_throw (error, "Invalid path uplink filename '..'");
-                   "Invalid path uplink filename '..'");
-      return FALSE;
     }
   if (strchr (name, '/') != NULL)
     {
-      g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED,
+      return glnx_throw (error, "Invalid / in filename %s", name);
-                   "Invalid / in filename %s", name);
-      return FALSE;
     }
   return TRUE;
 }

src/ostree/ot-builtin-commit.c

@@ -147,9 +147,7 @@ handle_statoverride_line (const char  *line,
   spc = strchr (line, ' ');
   if (spc == NULL)
     {
-      g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED,
+      return glnx_throw (error, "Malformed statoverride file (no space found)");
-                   "Malformed statoverride file (no space found)");
-      return FALSE;
     }
 
   mode_add = (guint32)(gint32)g_ascii_strtod (line, NULL);

src/ostree/ot-builtin-config.c

@@ -41,9 +41,8 @@ split_key_string (const char   *k,
   
   if (!dot)
     {
-      g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED,
+      return glnx_throw (error,
-                   "Key must be of the form \"sectionname.keyname\"");
+                        "Key must be of the form \"sectionname.keyname\"");
-      return FALSE;
     }
 
   *out_section = g_strndup (k, dot - k);