From 8ae03d6497db35b8d34be590d770e6d92beec9c6 Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Sun, 30 Oct 2016 13:52:51 +0000 Subject: [PATCH] load_metadata_internal: don't leak GBytes Found by valgrind memcheck. g_variant_new_from_bytes takes a ref to the bytes, so we need to release the original ref. Signed-off-by: Simon McVittie Closes: #556 Approved by: cgwalters --- src/libostree/ostree-repo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libostree/ostree-repo.c b/src/libostree/ostree-repo.c index 2e35faf8..1f866bbe 100644 --- a/src/libostree/ostree-repo.c +++ b/src/libostree/ostree-repo.c @@ -2593,7 +2593,7 @@ load_metadata_internal (OstreeRepo *self, } else { - GBytes *data = glnx_fd_readall_bytes (fd, cancellable, error); + g_autoptr(GBytes) data = glnx_fd_readall_bytes (fd, cancellable, error); if (!data) goto out; ret_variant = g_variant_new_from_bytes (ostree_metadata_variant_type (objtype),