packaging
/
ostree
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lib/deploy: Use _exit() for FIFREEZE watchdog 

This works around an (IMO) SpiderMonkey bug - it tries to
clean up in a shared library destructor, but doesn't install a
`pthread_atfork()` handler to unset its state.

Closes: https://github.com/ostreedev/ostree/issues/1262

Closes: #1264
Approved by: dbnicholson
This commit is contained in:
Colin Walters 2017-10-11 17:02:02 -04:00 committed by Atomic Bot
parent 1825f03fe7
commit 8f6ec62bfb
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/libostree/ostree-sysroot-deploy.c
View File

@ -1301,7 +1301,12 @@ fsfreeze_thaw_cycle (OstreeSysroot *self,
} }
if (debug_fifreeze) if (debug_fifreeze)
g_printerr ("fifreeze watchdog was run\n"); g_printerr ("fifreeze watchdog was run\n");
exit (EXIT_SUCCESS); /* We use _exit() rather than exit() to avoid tripping over any shared
* libraries in process that aren't fork() safe; for example gjs/spidermonkey:
* https://github.com/ostreedev/ostree/issues/1262
* This doesn't help for the err()/errx() calls above, but eh...
*/
_exit (EXIT_SUCCESS);
} }
else /* Parent process. */ else /* Parent process. */
{ {