packaging
/
ostree
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tree-wide: Add a few missing O_CLOEXEC 

I noticed an instance of this while working on https://github.com/ostreedev/ostree/pull/861
Which apparently I cargo-culted into the new system generator bits.
Let's break this out as a small concise change.

Closes: #866
Approved by: jlebon
This commit is contained in:
Colin Walters 2017-05-16 12:42:45 -04:00 committed by Atomic Bot
parent 30705889cb
commit 90cd7f7234
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/libostree/ostree-fetcher-curl.c
View File

@ -272,7 +272,7 @@ ensure_tmpfile (FetcherRequest *req, GError **error)
if (req->out_tmpfile_fd == -1) if (req->out_tmpfile_fd == -1)
{ {
if (!glnx_open_tmpfile_linkable_at (req->fetcher->tmpdir_dfd, ".", if (!glnx_open_tmpfile_linkable_at (req->fetcher->tmpdir_dfd, ".",
O_WRONLY, &req->out_tmpfile_fd, O_WRONLY | O_CLOEXEC, &req->out_tmpfile_fd,
&req->out_tmpfile, &req->out_tmpfile,
error)) error))
return FALSE; return FALSE;

2
src/libostree/ostree-impl-system-generator.c
View File

@ -174,7 +174,7 @@ _ostree_impl_system_generator (const char *ostree_cmdline,
glnx_fd_close int tmpfd = -1; glnx_fd_close int tmpfd = -1;
g_autofree char *tmppath = NULL; g_autofree char *tmppath = NULL;
if (!glnx_open_tmpfile_linkable_at (normal_dir_dfd, ".", O_WRONLY, if (!glnx_open_tmpfile_linkable_at (normal_dir_dfd, ".", O_WRONLY | O_CLOEXEC,
&tmpfd, &tmppath, error)) &tmpfd, &tmppath, error))
return FALSE; return FALSE;
g_autoptr(GOutputStream) outstream = g_unix_output_stream_new (tmpfd, FALSE); g_autoptr(GOutputStream) outstream = g_unix_output_stream_new (tmpfd, FALSE);

2
src/switchroot/ostree-prepare-root.c
View File

@ -54,7 +54,7 @@ touch_run_ostree (void)
{ {
int fd; int fd;
fd = open ("/run/ostree-booted", O_CREAT | O_WRONLY | O_NOCTTY, 0640); fd = open ("/run/ostree-booted", O_CREAT | O_WRONLY | O_NOCTTY | O_CLOEXEC, 0640);
/* We ignore failures here in case /run isn't mounted...not much we /* We ignore failures here in case /run isn't mounted...not much we
* can do about that, but we don't want to fail. * can do about that, but we don't want to fail.
*/ */