packaging
/
ostree
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

deployment: Fix gcc `-fanalyzer` warning 

In general, we're probably going to need to change most of our
`g_return_if_fail` to `g_assert`.  The analyzer flags that
the function can return `NULL`, but the caller isn't prepared for
this.

In practice, let's abort.
This commit is contained in:
Colin Walters 2021-10-08 08:59:52 -04:00
parent a8eed03a19
commit 9a7f9c2095
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/libostree/ostree-deployment.c
View File

@ -374,9 +374,9 @@ ostree_deployment_new (int index,
OstreeDeployment *self; OstreeDeployment *self;
/* index may be -1 */ /* index may be -1 */
g_return_val_if_fail (osname != NULL, NULL); g_assert (osname != NULL);
g_return_val_if_fail (csum != NULL, NULL); g_assert (csum != NULL);
g_return_val_if_fail (deployserial >= 0, NULL); g_assert (deployserial >= 0);
/* We can have "disconnected" deployments that don't have a /* We can have "disconnected" deployments that don't have a
bootcsum/serial */ bootcsum/serial */