packaging
/
ostree
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

signing: Remove g_debug(__FUNCTION__) 

This type of thing is better done via `gdb` and/or userspace
tracing (systemtap/bpftrace etc.)
This commit is contained in:
Colin Walters 2020-02-14 15:52:48 +00:00 committed by Denis Pynkin
parent e2bd2abc67
commit 9d02199675
3 changed files with 0 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/libostree/ostree-sign-dummy.c
View File

@ -56,7 +56,6 @@ G_DEFINE_TYPE_WITH_CODE (OstreeSignDummy, _ostree_sign_dummy, G_TYPE_OBJECT,
static void static void
ostree_sign_dummy_iface_init (OstreeSignInterface *self) ostree_sign_dummy_iface_init (OstreeSignInterface *self)
{ {
g_debug ("%s enter", __FUNCTION__);
self->get_name = ostree_sign_dummy_get_name; self->get_name = ostree_sign_dummy_get_name;
self->data = ostree_sign_dummy_data; self->data = ostree_sign_dummy_data;
@ -72,13 +71,11 @@ ostree_sign_dummy_iface_init (OstreeSignInterface *self)
static void static void
_ostree_sign_dummy_class_init (OstreeSignDummyClass *self) _ostree_sign_dummy_class_init (OstreeSignDummyClass *self)
{ {
g_debug ("%s enter", __FUNCTION__);
} }
static void static void
_ostree_sign_dummy_init (OstreeSignDummy *self) _ostree_sign_dummy_init (OstreeSignDummy *self)
{ {
g_debug ("%s enter", __FUNCTION__);
self->sk_ascii = NULL; self->sk_ascii = NULL;
self->pk_ascii = NULL; self->pk_ascii = NULL;
@ -86,7 +83,6 @@ _ostree_sign_dummy_init (OstreeSignDummy *self)
gboolean ostree_sign_dummy_set_sk (OstreeSign *self, GVariant *key, GError **error) gboolean ostree_sign_dummy_set_sk (OstreeSign *self, GVariant *key, GError **error)
{ {
g_debug ("%s enter", __FUNCTION__);
OstreeSignDummy *sign = _ostree_sign_dummy_get_instance_private(OSTREE_SIGN_DUMMY(self)); OstreeSignDummy *sign = _ostree_sign_dummy_get_instance_private(OSTREE_SIGN_DUMMY(self));
@ -99,7 +95,6 @@ gboolean ostree_sign_dummy_set_sk (OstreeSign *self, GVariant *key, GError **err
gboolean ostree_sign_dummy_set_pk (OstreeSign *self, GVariant *key, GError **error) gboolean ostree_sign_dummy_set_pk (OstreeSign *self, GVariant *key, GError **error)
{ {
g_debug ("%s enter", __FUNCTION__);
OstreeSignDummy *sign = _ostree_sign_dummy_get_instance_private(OSTREE_SIGN_DUMMY(self)); OstreeSignDummy *sign = _ostree_sign_dummy_get_instance_private(OSTREE_SIGN_DUMMY(self));
@ -117,7 +112,6 @@ gboolean ostree_sign_dummy_data (OstreeSign *self,
GError **error) GError **error)
{ {
g_debug ("%s enter", __FUNCTION__);
g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE); g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE);
OstreeSignDummy *sign = _ostree_sign_dummy_get_instance_private(OSTREE_SIGN_DUMMY(self)); OstreeSignDummy *sign = _ostree_sign_dummy_get_instance_private(OSTREE_SIGN_DUMMY(self));
@ -129,7 +123,6 @@ gboolean ostree_sign_dummy_data (OstreeSign *self,
const gchar * ostree_sign_dummy_get_name (OstreeSign *self) const gchar * ostree_sign_dummy_get_name (OstreeSign *self)
{ {
g_debug ("%s enter", __FUNCTION__);
g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE); g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE);
return OSTREE_SIGN_DUMMY_NAME; return OSTREE_SIGN_DUMMY_NAME;
@ -137,14 +130,12 @@ const gchar * ostree_sign_dummy_get_name (OstreeSign *self)
const gchar * ostree_sign_dummy_metadata_key (OstreeSign *self) const gchar * ostree_sign_dummy_metadata_key (OstreeSign *self)
{ {
g_debug ("%s enter", __FUNCTION__);
return OSTREE_SIGN_METADATA_DUMMY_KEY; return OSTREE_SIGN_METADATA_DUMMY_KEY;
} }
const gchar * ostree_sign_dummy_metadata_format (OstreeSign *self) const gchar * ostree_sign_dummy_metadata_format (OstreeSign *self)
{ {
g_debug ("%s enter", __FUNCTION__);
return OSTREE_SIGN_METADATA_DUMMY_TYPE; return OSTREE_SIGN_METADATA_DUMMY_TYPE;
} }
@ -154,7 +145,6 @@ gboolean ostree_sign_dummy_data_verify (OstreeSign *self,
GVariant *signatures, GVariant *signatures,
GError **error) GError **error)
{ {
g_debug ("%s enter", __FUNCTION__);
g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE); g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE);
g_return_val_if_fail (data != NULL, FALSE); g_return_val_if_fail (data != NULL, FALSE);

17
src/libostree/ostree-sign-ed25519.c
View File

@ -68,7 +68,6 @@ G_DEFINE_TYPE_WITH_CODE (OstreeSignEd25519, _ostree_sign_ed25519, G_TYPE_OBJECT,
static void static void
ostree_sign_ed25519_iface_init (OstreeSignInterface *self) ostree_sign_ed25519_iface_init (OstreeSignInterface *self)
{ {
g_debug ("%s enter", __FUNCTION__);
self->data = ostree_sign_ed25519_data; self->data = ostree_sign_ed25519_data;
self->data_verify = ostree_sign_ed25519_data_verify; self->data_verify = ostree_sign_ed25519_data_verify;
@ -85,13 +84,11 @@ ostree_sign_ed25519_iface_init (OstreeSignInterface *self)
static void static void
_ostree_sign_ed25519_class_init (OstreeSignEd25519Class *self) _ostree_sign_ed25519_class_init (OstreeSignEd25519Class *self)
{ {
g_debug ("%s enter", __FUNCTION__);
} }
static void static void
_ostree_sign_ed25519_init (OstreeSignEd25519 *self) _ostree_sign_ed25519_init (OstreeSignEd25519 *self)
{ {
g_debug ("%s enter", __FUNCTION__);
self->state = ED25519_OK; self->state = ED25519_OK;
self->secret_key = NULL; self->secret_key = NULL;
@ -133,7 +130,6 @@ gboolean ostree_sign_ed25519_data (OstreeSign *self,
GError **error) GError **error)
{ {
g_debug ("%s enter", __FUNCTION__);
g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE); g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE);
OstreeSignEd25519 *sign = _ostree_sign_ed25519_get_instance_private(OSTREE_SIGN_ED25519(self)); OstreeSignEd25519 *sign = _ostree_sign_ed25519_get_instance_private(OSTREE_SIGN_ED25519(self));
@ -186,7 +182,6 @@ gboolean ostree_sign_ed25519_data_verify (OstreeSign *self,
GVariant *signatures, GVariant *signatures,
GError **error) GError **error)
{ {
g_debug ("%s enter", __FUNCTION__);
g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE); g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE);
g_return_val_if_fail (data != NULL, FALSE); g_return_val_if_fail (data != NULL, FALSE);
gboolean ret = FALSE; gboolean ret = FALSE;
@ -283,7 +278,6 @@ out:
const gchar * ostree_sign_ed25519_get_name (OstreeSign *self) const gchar * ostree_sign_ed25519_get_name (OstreeSign *self)
{ {
g_debug ("%s enter", __FUNCTION__);
g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE); g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE);
return OSTREE_SIGN_ED25519_NAME; return OSTREE_SIGN_ED25519_NAME;
@ -291,14 +285,12 @@ const gchar * ostree_sign_ed25519_get_name (OstreeSign *self)
const gchar * ostree_sign_ed25519_metadata_key (OstreeSign *self) const gchar * ostree_sign_ed25519_metadata_key (OstreeSign *self)
{ {
g_debug ("%s enter", __FUNCTION__);
return OSTREE_SIGN_METADATA_ED25519_KEY; return OSTREE_SIGN_METADATA_ED25519_KEY;
} }
const gchar * ostree_sign_ed25519_metadata_format (OstreeSign *self) const gchar * ostree_sign_ed25519_metadata_format (OstreeSign *self)
{ {
g_debug ("%s enter", __FUNCTION__);
return OSTREE_SIGN_METADATA_ED25519_TYPE; return OSTREE_SIGN_METADATA_ED25519_TYPE;
} }
@ -306,7 +298,6 @@ const gchar * ostree_sign_ed25519_metadata_format (OstreeSign *self)
gboolean ostree_sign_ed25519_clear_keys (OstreeSign *self, gboolean ostree_sign_ed25519_clear_keys (OstreeSign *self,
GError **error) GError **error)
{ {
g_debug ("%s enter", __FUNCTION__);
g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE); g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE);
OstreeSignEd25519 *sign = _ostree_sign_ed25519_get_instance_private(OSTREE_SIGN_ED25519(self)); OstreeSignEd25519 *sign = _ostree_sign_ed25519_get_instance_private(OSTREE_SIGN_ED25519(self));
@ -352,7 +343,6 @@ gboolean ostree_sign_ed25519_set_sk (OstreeSign *self,
GVariant *secret_key, GVariant *secret_key,
GError **error) GError **error)
{ {
g_debug ("%s enter", __FUNCTION__);
g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE); g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE);
@ -403,7 +393,6 @@ gboolean ostree_sign_ed25519_set_pk (OstreeSign *self,
GVariant *public_key, GVariant *public_key,
GError **error) GError **error)
{ {
g_debug ("%s enter", __FUNCTION__);
g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE); g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE);
if (!ostree_sign_ed25519_clear_keys (self, error)) if (!ostree_sign_ed25519_clear_keys (self, error))
@ -420,7 +409,6 @@ gboolean ostree_sign_ed25519_add_pk (OstreeSign *self,
GVariant *public_key, GVariant *public_key,
GError **error) GError **error)
{ {
g_debug ("%s enter", __FUNCTION__);
g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE); g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE);
OstreeSignEd25519 *sign = _ostree_sign_ed25519_get_instance_private(OSTREE_SIGN_ED25519(self)); OstreeSignEd25519 *sign = _ostree_sign_ed25519_get_instance_private(OSTREE_SIGN_ED25519(self));
@ -469,7 +457,6 @@ _ed25519_add_revoked (OstreeSign *self,
GVariant *revoked_key, GVariant *revoked_key,
GError **error) GError **error)
{ {
g_debug ("%s enter", __FUNCTION__);
g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE); g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE);
if (!g_variant_is_of_type (revoked_key, G_VARIANT_TYPE_STRING)) if (!g_variant_is_of_type (revoked_key, G_VARIANT_TYPE_STRING))
@ -506,7 +493,6 @@ _load_pk_from_stream (OstreeSign *self,
gboolean trusted, gboolean trusted,
GError **error) GError **error)
{ {
g_debug ("%s enter", __FUNCTION__);
g_return_val_if_fail (key_data_in, FALSE); g_return_val_if_fail (key_data_in, FALSE);
#ifdef HAVE_LIBSODIUM #ifdef HAVE_LIBSODIUM
gboolean ret = FALSE; gboolean ret = FALSE;
@ -558,7 +544,6 @@ _load_pk_from_file (OstreeSign *self,
gboolean trusted, gboolean trusted,
GError **error) GError **error)
{ {
g_debug ("%s enter", __FUNCTION__);
g_debug ("Processing file '%s'", filename); g_debug ("Processing file '%s'", filename);
g_autoptr (GFile) keyfile = NULL; g_autoptr (GFile) keyfile = NULL;
@ -602,7 +587,6 @@ _ed25519_load_pk (OstreeSign *self,
gboolean trusted, gboolean trusted,
GError **error) GError **error)
{ {
g_debug ("%s enter", __FUNCTION__);
gboolean ret = FALSE; gboolean ret = FALSE;
const gchar *custom_dir = NULL; const gchar *custom_dir = NULL;
@ -687,7 +671,6 @@ ostree_sign_ed25519_load_pk (OstreeSign *self,
GVariant *options, GVariant *options,
GError **error) GError **error)
{ {
g_debug ("%s enter", __FUNCTION__);
const gchar *filename = NULL; const gchar *filename = NULL;

16
src/libostree/ostree-sign.c
View File

@ -98,7 +98,6 @@ ostree_sign_default_init (OstreeSignInterface *iface)
const gchar * const gchar *
ostree_sign_metadata_key (OstreeSign *self) ostree_sign_metadata_key (OstreeSign *self)
{ {
g_debug ("%s enter", __FUNCTION__);
g_return_val_if_fail (OSTREE_SIGN_GET_IFACE (self)->metadata_key != NULL, NULL); g_return_val_if_fail (OSTREE_SIGN_GET_IFACE (self)->metadata_key != NULL, NULL);
return OSTREE_SIGN_GET_IFACE (self)->metadata_key (self); return OSTREE_SIGN_GET_IFACE (self)->metadata_key (self);
@ -119,7 +118,6 @@ ostree_sign_metadata_key (OstreeSign *self)
const gchar * const gchar *
ostree_sign_metadata_format (OstreeSign *self) ostree_sign_metadata_format (OstreeSign *self)
{ {
g_debug ("%s enter", __FUNCTION__);
g_return_val_if_fail (OSTREE_SIGN_GET_IFACE (self)->metadata_format != NULL, NULL); g_return_val_if_fail (OSTREE_SIGN_GET_IFACE (self)->metadata_format != NULL, NULL);
return OSTREE_SIGN_GET_IFACE (self)->metadata_format (self); return OSTREE_SIGN_GET_IFACE (self)->metadata_format (self);
@ -140,7 +138,6 @@ gboolean
ostree_sign_clear_keys (OstreeSign *self, ostree_sign_clear_keys (OstreeSign *self,
GError **error) GError **error)
{ {
g_debug ("%s enter", __FUNCTION__);
if (OSTREE_SIGN_GET_IFACE (self)->clear_keys == NULL) if (OSTREE_SIGN_GET_IFACE (self)->clear_keys == NULL)
return TRUE; return TRUE;
@ -168,7 +165,6 @@ ostree_sign_set_sk (OstreeSign *self,
GVariant *secret_key, GVariant *secret_key,
GError **error) GError **error)
{ {
g_debug ("%s enter", __FUNCTION__);
if (OSTREE_SIGN_GET_IFACE (self)->set_sk == NULL) if (OSTREE_SIGN_GET_IFACE (self)->set_sk == NULL)
return TRUE; return TRUE;
@ -197,7 +193,6 @@ ostree_sign_set_pk (OstreeSign *self,
GVariant *public_key, GVariant *public_key,
GError **error) GError **error)
{ {
g_debug ("%s enter", __FUNCTION__);
if (OSTREE_SIGN_GET_IFACE (self)->set_pk == NULL) if (OSTREE_SIGN_GET_IFACE (self)->set_pk == NULL)
return TRUE; return TRUE;
@ -226,7 +221,6 @@ ostree_sign_add_pk (OstreeSign *self,
GVariant *public_key, GVariant *public_key,
GError **error) GError **error)
{ {
g_debug ("%s enter", __FUNCTION__);
if (OSTREE_SIGN_GET_IFACE (self)->add_pk == NULL) if (OSTREE_SIGN_GET_IFACE (self)->add_pk == NULL)
return TRUE; return TRUE;
@ -266,7 +260,6 @@ ostree_sign_load_pk (OstreeSign *self,
GVariant *options, GVariant *options,
GError **error) GError **error)
{ {
g_debug ("%s enter", __FUNCTION__);
if (OSTREE_SIGN_GET_IFACE (self)->load_pk == NULL) if (OSTREE_SIGN_GET_IFACE (self)->load_pk == NULL)
return TRUE; return TRUE;
@ -300,7 +293,6 @@ ostree_sign_data (OstreeSign *self,
GError **error) GError **error)
{ {
g_debug ("%s enter", __FUNCTION__);
g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE); g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE);
g_return_val_if_fail (OSTREE_SIGN_GET_IFACE (self)->data != NULL, FALSE); g_return_val_if_fail (OSTREE_SIGN_GET_IFACE (self)->data != NULL, FALSE);
@ -331,7 +323,6 @@ ostree_sign_data_verify (OstreeSign *self,
GVariant *signatures, GVariant *signatures,
GError **error) GError **error)
{ {
g_debug ("%s enter", __FUNCTION__);
g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE); g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE);
g_return_val_if_fail (OSTREE_SIGN_GET_IFACE (self)->data_verify != NULL, FALSE); g_return_val_if_fail (OSTREE_SIGN_GET_IFACE (self)->data_verify != NULL, FALSE);
@ -346,7 +337,6 @@ _sign_detached_metadata_append (OstreeSign *self,
GVariant *existing_metadata, GVariant *existing_metadata,
GBytes *signature_bytes) GBytes *signature_bytes)
{ {
g_debug ("%s enter", __FUNCTION__);
g_return_val_if_fail (signature_bytes != NULL, FALSE); g_return_val_if_fail (signature_bytes != NULL, FALSE);
GVariantDict metadata_dict; GVariantDict metadata_dict;
@ -401,7 +391,6 @@ ostree_sign_commit_verify (OstreeSign *self,
GError **error) GError **error)
{ {
g_debug ("%s enter", __FUNCTION__);
g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE); g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE);
g_autoptr(GVariant) commit_variant = NULL; g_autoptr(GVariant) commit_variant = NULL;
@ -455,7 +444,6 @@ ostree_sign_commit_verify (OstreeSign *self,
const gchar * const gchar *
ostree_sign_get_name (OstreeSign *self) ostree_sign_get_name (OstreeSign *self)
{ {
g_debug ("%s enter", __FUNCTION__);
g_return_val_if_fail (OSTREE_IS_SIGN (self), NULL); g_return_val_if_fail (OSTREE_IS_SIGN (self), NULL);
g_return_val_if_fail (OSTREE_SIGN_GET_IFACE (self)->get_name != NULL, NULL); g_return_val_if_fail (OSTREE_SIGN_GET_IFACE (self)->get_name != NULL, NULL);
@ -487,7 +475,6 @@ ostree_sign_commit (OstreeSign *self,
GCancellable *cancellable, GCancellable *cancellable,
GError **error) GError **error)
{ {
g_debug ("%s enter", __FUNCTION__);
g_autoptr(GBytes) commit_data = NULL; g_autoptr(GBytes) commit_data = NULL;
g_autoptr(GBytes) signature = NULL; g_autoptr(GBytes) signature = NULL;
@ -537,7 +524,6 @@ ostree_sign_commit (OstreeSign *self,
GStrv GStrv
ostree_sign_list_names(void) ostree_sign_list_names(void)
{ {
g_debug ("%s enter", __FUNCTION__);
GStrv names = g_new0 (char *, G_N_ELEMENTS(sign_types) + 1); GStrv names = g_new0 (char *, G_N_ELEMENTS(sign_types) + 1);
gint i = 0; gint i = 0;
@ -567,7 +553,6 @@ ostree_sign_list_names(void)
OstreeSign * OstreeSign *
ostree_sign_get_by_name (const gchar *name, GError **error) ostree_sign_get_by_name (const gchar *name, GError **error)
{ {
g_debug ("%s enter", __FUNCTION__);
OstreeSign *sign = NULL; OstreeSign *sign = NULL;
@ -616,7 +601,6 @@ ostree_sign_summary (OstreeSign *self,
GCancellable *cancellable, GCancellable *cancellable,
GError **error) GError **error)
{ {
g_debug ("%s enter", __FUNCTION__);
g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE); g_return_val_if_fail (OSTREE_IS_SIGN (self), FALSE);
g_return_val_if_fail (OSTREE_IS_REPO (repo), FALSE); g_return_val_if_fail (OSTREE_IS_REPO (repo), FALSE);