d/p/Terminate-individual-tests-after-10-minutes.patch: replace d/p/debian/Terminate-individual-tests-after-half-an-hour.patch with the version that I sent upstream, which uses SIGABRT and terminates the tests sooner

This commit is contained in:
Simon McVittie 2016-12-01 12:38:14 +00:00
parent 384b7abbd9
commit 9dd341b8b4
3 changed files with 15 additions and 5 deletions

5
debian/changelog vendored
View File

@ -8,6 +8,11 @@ ostree (2016.14-2) UNRELEASED; urgency=medium
However, these are not regressions, so we should not FTBFS just However, these are not regressions, so we should not FTBFS just
because we happen to have been unlucky during build. because we happen to have been unlucky during build.
* d/p/Terminate-individual-tests-after-10-minutes.patch:
replace d/p/debian/Terminate-individual-tests-after-half-an-hour.patch
with the version that I sent upstream, which uses SIGABRT and
terminates the tests sooner
-- Simon McVittie <smcv@debian.org> Thu, 01 Dec 2016 12:29:00 +0000 -- Simon McVittie <smcv@debian.org> Thu, 01 Dec 2016 12:29:00 +0000
ostree (2016.14-1) unstable; urgency=medium ostree (2016.14-1) unstable; urgency=medium

View File

@ -1,6 +1,6 @@
From: Simon McVittie <smcv@debian.org> From: Simon McVittie <smcv@debian.org>
Date: Fri, 9 Sep 2016 08:23:36 +0100 Date: Thu, 1 Dec 2016 11:25:33 +0000
Subject: Terminate individual tests after half an hour Subject: Terminate individual tests after 10 minutes
While using the Automake parallel test harness, if a test hangs for While using the Automake parallel test harness, if a test hangs for
long enough for an external watchdog to kill the entire build process long enough for an external watchdog to kill the entire build process
@ -8,13 +8,18 @@ long enough for an external watchdog to kill the entire build process
stdout/stderr), the logs will not be shown. If we make an individual stdout/stderr), the logs will not be shown. If we make an individual
test time out sooner, logs are more likely to be shown. test time out sooner, logs are more likely to be shown.
We use SIGABRT so that the process(es) under test will dump core,
allowing the point at which ostree is blocking to be analyzed.
After 1 minute, if any have not died, we kill them again with SIGKILL.
Signed-off-by: Simon McVittie <smcv@debian.org> Signed-off-by: Simon McVittie <smcv@debian.org>
Forwarded: https://github.com/ostreedev/ostree/pull/607
--- ---
buildutil/tap-test | 2 +- buildutil/tap-test | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-) 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/buildutil/tap-test b/buildutil/tap-test diff --git a/buildutil/tap-test b/buildutil/tap-test
index c8da31e..fd79122 100755 index c8da31e..4adee45 100755
--- a/buildutil/tap-test --- a/buildutil/tap-test
+++ b/buildutil/tap-test +++ b/buildutil/tap-test
@@ -19,7 +19,7 @@ function skip_cleanup() { @@ -19,7 +19,7 @@ function skip_cleanup() {
@ -22,7 +27,7 @@ index c8da31e..fd79122 100755
} }
cd ${tempdir} cd ${tempdir}
-${srcd}/${bn} -k --tap -${srcd}/${bn} -k --tap
+timeout --kill-after=60 1800 ${srcd}/${bn} -k --tap +timeout --kill-after=60 --signal=ABRT 600 ${srcd}/${bn} -k --tap
rc=$? rc=$?
case "${TEST_SKIP_CLEANUP:-}" in case "${TEST_SKIP_CLEANUP:-}" in
no|"") cleanup ;; no|"") cleanup ;;

View File

@ -4,4 +4,4 @@ ostree-repo-traverse-Don-t-leak-floating-GVariant.patch
pull_with_options-Don-t-leak-csum_v.patch pull_with_options-Don-t-leak-csum_v.patch
pull-Don-t-leak-delta-superblock-variants.patch pull-Don-t-leak-delta-superblock-variants.patch
delta-compilation-Fix-leak.patch delta-compilation-Fix-leak.patch
debian/Terminate-individual-tests-after-half-an-hour.patch Terminate-individual-tests-after-10-minutes.patch