From a02b425fc241556d6e4aed1ed69e00b77e3cc758 Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Fri, 18 Mar 2016 08:43:53 -0400 Subject: [PATCH] tests: Strengthen test tmpdir sanity check, be compat with ginsttest saving GNOME Continuous uses ginstest-runner --report-directory, which causes the tests to save their tmpdirs persistently. This also means the result directories didn't match the `/(var/)?tmp` regexp, which broke the ostree tests in GContinuous. Fix this by simply asserting that the tmpdir either has `.tmpdir` or nothing. --- tests/libtest.sh | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/tests/libtest.sh b/tests/libtest.sh index 0db3382d..06982d21 100755 --- a/tests/libtest.sh +++ b/tests/libtest.sh @@ -25,13 +25,14 @@ assert_not_reached () { test_tmpdir=$(pwd) -# Extra sanity checks -if test -d .git; then - assert_not_reached "Found .git, not in a tempdir?" -fi -echo "in ${test_tmpdir}" -if ! echo ${test_tmpdir} | grep -E -q '^/(var/)?tmp'; then - assert_not_reached "Not in /tmp or /var/tmp" +# Sanity check that we're in a tmpdir that has +# just .testtmp (created by tap-driver for `make check`, +# or nothing at all (as ginstest-runner does) +if ! test -f .testtmp; then + files=$(ls) + if test -n "${files}"; then + assert_not_reached "test tmpdir=${test_tmpdir} is not empty; run this test via \`make check TESTS=\`, not directly" + fi fi export G_DEBUG=fatal-warnings