From a118410b85a5b4ff333813da21768df3f4b9e911 Mon Sep 17 00:00:00 2001 From: Luca BRUNO Date: Wed, 26 Oct 2022 11:12:37 +0000 Subject: [PATCH] lib/repo-refs: properly return an error value This tweaks a logic check in order to return a proper error value when the related condition is not satisfied. --- src/libostree/ostree-repo-refs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libostree/ostree-repo-refs.c b/src/libostree/ostree-repo-refs.c index 86bd27c5..9ac2cc09 100644 --- a/src/libostree/ostree-repo-refs.c +++ b/src/libostree/ostree-repo-refs.c @@ -36,7 +36,8 @@ add_ref_to_set (const char *remote, GCancellable *cancellable, GError **error) { - g_return_val_if_fail (remote == NULL || collection_id == NULL, FALSE); + if (remote != NULL && collection_id != NULL) + return glnx_throw (error, "Cannot process both a remote and a collection ID"); gsize len; char *contents = glnx_file_get_contents_utf8_at (base_fd, path, &len, cancellable, error);