From bb2649a8c087105542edccbead26b6d9b8fc366a Mon Sep 17 00:00:00 2001 From: Alexander Larsson Date: Tue, 8 Sep 2020 11:37:33 +0200 Subject: [PATCH] Fix leak when signing _ostree_detached_metadata_append_gpg_sig() was returning a floating ref, but all users were using g_autoptr. Fix it by adding a ref-sink. --- src/libostree/ostree-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libostree/ostree-core.c b/src/libostree/ostree-core.c index 523f57c0..29528fa5 100644 --- a/src/libostree/ostree-core.c +++ b/src/libostree/ostree-core.c @@ -2675,7 +2675,7 @@ _ostree_detached_metadata_append_gpg_sig (GVariant *existing_metadata, _OSTREE_METADATA_GPGSIGS_NAME, g_variant_builder_end (signature_builder)); - return g_variant_dict_end (&metadata_dict); + return g_variant_ref_sink (g_variant_dict_end (&metadata_dict)); } #endif /* OSTREE_DISABLE_GPGME */