lib/core: Use GBytes for file headers

This simplifies a lot of code; the header function was structured
to write to an input stream, but many callers only wanted the checksum,
so it's simpler (and error-free) to simply allocate a whole buffer
and checksum that.

For the callers that want to write it, it's also still simpler to allocate the
buffer and write the whole thing rather than having this function do the
writing.

A lot of the complexity here again is a legacy of the packfile code, which is
dead.

This is prep for faster regfile commits where we can avoid `G{In,Out}putStream`.

Closes: #1257
Approved by: jlebon

src/libostree/ostree-core-private.h

@@ -68,17 +68,11 @@ G_BEGIN_DECLS
 #define _OSTREE_ZLIB_FILE_HEADER_GVARIANT_FORMAT G_VARIANT_TYPE ("(tuuuusa(ayay))")
 
 
-GVariant *_ostree_file_header_new (GFileInfo         *file_info,
-                                   GVariant          *xattrs);
+GBytes *_ostree_file_header_new (GFileInfo         *file_info,
+                                 GVariant          *xattrs);
 
-GVariant *_ostree_zlib_file_header_new (GFileInfo         *file_info,
-                                        GVariant          *xattrs);
-
-gboolean _ostree_write_variant_with_size (GOutputStream      *output,
-                                          GVariant           *variant,
-                                          OtChecksum         *checksum,
-                                          GCancellable       *cancellable,
-                                          GError            **error);
+GBytes *_ostree_zlib_file_header_new (GFileInfo         *file_info,
+                                      GVariant          *xattrs);
 
 gboolean
 _ostree_make_temporary_symlink_at (int             tmp_dirfd,