packaging
/
ostree
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lib/commit: Use direct repo writes if fsync is disabled 

For situations where fsync is disabled, there's basically
no reason to do the whole "staging directory" dance.  Just
write directly into the repo.

Today I use `fsync=false` for my build/cache repos.

I briefly considered not allocating a tmpdir at all
in this case, but we actually do want the txn tmpdir
for the non-`O_TMPFILE` case.

Part of https://github.com/ostreedev/ostree/issues/1184

Closes: #1354
Approved by: giuseppe
This commit is contained in:
Colin Walters 2017-11-28 15:17:10 -05:00 committed by Atomic Bot
parent a1745e1a79
commit bd6a15e7a3
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/libostree/ostree-repo-commit.c
View File

@ -38,13 +38,14 @@
#include "ostree-checksum-input-stream.h" #include "ostree-checksum-input-stream.h"
#include "ostree-varint.h" #include "ostree-varint.h"
/* In most cases, we write into a staging dir for commit, but we also allow /* If fsync is enabled and we're in a txn, we write into a staging dir for
* direct writes into objects/ for e.g. hardlink imports. * commit, but we also allow direct writes into objects/ for e.g. hardlink
* imports.
*/ */
static int static int
commit_dest_dfd (OstreeRepo *self) commit_dest_dfd (OstreeRepo *self)
{ {
if (self->in_transaction) if (self->in_transaction && !self->disable_fsync)
return self->commit_stagedir.fd; return self->commit_stagedir.fd;
else else
return self->objects_dir_fd; return self->objects_dir_fd;