ostree_repo_checkout_tree_at: New API for checkouts
rpm-ostree currently uses ostree_repo_checkout_tree(), which as a side effect will use the uncompressed objects cache by default. This is rather annoying if you're using rpm-ostree on a server-side repository, because if you then rsync the repo, you'll be syncing out the uncompressed objects unless you exclude them. We added the ability to disable the uncompressed cache in the repository config to fix this, but it's better to allow application control over this. The uncompressed cache will in some future version become opt in as well. This new API further: - Drops the `GFile` usage in favor of `openat` APIs - Improves ergonomics by avoiding callers having to query the source `GFileInfo` (and carry around a copy of `OSTREE_GIO_FAST_QUERYINFO`) - Has a more extensible options structure Per the comment, I rather crudely have the `ostree checkout` builtin call both APIs to ensure some testing coverage. However, I'd like to in the future have easier-to-set-up testing code that calls `libtest.sh` to set up dummy data.
This commit is contained in:
1 parent
115e05746b
commit
c2aabcac3b
5 files changed
+236
-78
No files matched your search
+20
-1
@@ -19,7 +19,7 @@
|
||||
|
||||
set -e
|
||||
|
||||
echo "1..47"
|
||||
echo "1..48"
|
||||
|
||||
$OSTREE checkout test2 checkout-test2
|
||||
echo "ok checkout"
|
||||
@@ -362,6 +362,25 @@ if $OSTREE commit -b test2 -s "Attempt to commit a FIFO" 2>../errmsg; then
|
||||
fi
|
||||
echo "ok commit of fifo was rejected"
|
||||
|
||||
cd ${test_tmpdir}
|
||||
rm repo2 -rf
|
||||
mkdir repo2
|
||||
${CMD_PREFIX} ostree --repo=repo2 init --mode=archive-z2
|
||||
${CMD_PREFIX} ostree --repo=repo2 pull-local repo
|
||||
rm -rf test2-checkout
|
||||
${CMD_PREFIX} ostree --repo=repo2 checkout -U --disable-cache test2 test2-checkout
|
||||
if test -d repo2/uncompressed-objects-cache; then
|
||||
ls repo2/uncompressed-objects-cache > ls.txt
|
||||
if test -s ls.txt; then
|
||||
assert_not_reached "repo has uncompressed objects"
|
||||
fi
|
||||
fi
|
||||
rm test2-checkout -rf
|
||||
${CMD_PREFIX} ostree --repo=repo2 checkout -U test2 test2-checkout
|
||||
assert_file_has_content test2-checkout/baz/cow moo
|
||||
assert_has_dir repo2/uncompressed-objects-cache
|
||||
echo "ok disable cache checkout"
|
||||
|
||||
cd ${test_tmpdir}
|
||||
rm -rf test2-checkout
|
||||
mkdir -p test2-checkout
|
||||
|
||||
Reference in new issue
Block a user