From d044bfeb30b6a763487a3e9ccc2b3dc55dd9f92b Mon Sep 17 00:00:00 2001 From: Alexander Larsson Date: Mon, 10 Dec 2018 13:51:14 +0100 Subject: [PATCH] Fix leak in ostree_content_stream_parse() We need to ref_sink new GVariants for autoptr to work Closes: #1784 Approved by: cgwalters --- src/libostree/ostree-core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libostree/ostree-core.c b/src/libostree/ostree-core.c index 080137f3..4e1a67e0 100644 --- a/src/libostree/ostree-core.c +++ b/src/libostree/ostree-core.c @@ -626,9 +626,9 @@ ostree_content_stream_parse (gboolean compressed, cancellable, error)) return FALSE; g_autoptr(GVariant) file_header = - g_variant_new_from_data (compressed ? _OSTREE_ZLIB_FILE_HEADER_GVARIANT_FORMAT : _OSTREE_FILE_HEADER_GVARIANT_FORMAT, - buf, archive_header_size, trusted, - g_free, buf); + g_variant_ref_sink(g_variant_new_from_data (compressed ? _OSTREE_ZLIB_FILE_HEADER_GVARIANT_FORMAT : _OSTREE_FILE_HEADER_GVARIANT_FORMAT, + buf, archive_header_size, trusted, + g_free, buf)); buf = NULL; g_autoptr(GFileInfo) ret_file_info = NULL; g_autoptr(GVariant) ret_xattrs = NULL;