Use { 0, } for structure initialization rather than memset()
It's cleaner, safer, and I had a totally wrong idea stuck in my head about why memset() should be used. https://bugzilla.gnome.org/show_bug.cgi?id=705968
This commit is contained in:
1 parent
5f90502482
commit
eaee309112
6 files changed
+7
-19
No files matched your search
@@ -364,12 +364,11 @@ fetch_uri (OtPullData *pull_data,
|
||||
gboolean ret = FALSE;
|
||||
gs_free char *uri_string = NULL;
|
||||
gs_unref_object SoupRequest *request = NULL;
|
||||
OstreeFetchUriData fetch_data;
|
||||
OstreeFetchUriData fetch_data = { 0, };
|
||||
|
||||
if (g_cancellable_set_error_if_cancelled (cancellable, error))
|
||||
return FALSE;
|
||||
|
||||
memset (&fetch_data, 0, sizeof (fetch_data));
|
||||
fetch_data.pull_data = pull_data;
|
||||
|
||||
uri_string = soup_uri_to_string (uri, FALSE);
|
||||
@@ -1184,7 +1183,7 @@ ostree_repo_pull (OstreeRepo *self,
|
||||
gs_free char *branch_rev = NULL;
|
||||
gs_free char *remote_mode_str = NULL;
|
||||
GSource *queue_src = NULL;
|
||||
OtPullData pull_data_real;
|
||||
OtPullData pull_data_real = { 0, };
|
||||
OtPullData *pull_data = &pull_data_real;
|
||||
SoupURI *summary_uri = NULL;
|
||||
GKeyFile *config = NULL;
|
||||
@@ -1194,8 +1193,6 @@ ostree_repo_pull (OstreeRepo *self,
|
||||
guint64 start_time;
|
||||
guint64 end_time;
|
||||
|
||||
memset (pull_data, 0, sizeof (*pull_data));
|
||||
|
||||
pull_data->async_error = error;
|
||||
pull_data->main_context = g_main_context_get_thread_default ();
|
||||
pull_data->loop = g_main_loop_new (pull_data->main_context, FALSE);
|
||||
|
||||
Reference in new issue
Block a user