From fbed380483525fb0780d07d904e8144b7e86ab0b Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Fri, 18 Oct 2019 15:06:51 +0000 Subject: [PATCH] lib/checksum-utils: Use g_memdup() This is clearer and silences a scan-build warning. --- src/libotutil/ot-checksum-utils.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/libotutil/ot-checksum-utils.c b/src/libotutil/ot-checksum-utils.c index 6eb6fdc0..66767368 100644 --- a/src/libotutil/ot-checksum-utils.c +++ b/src/libotutil/ot-checksum-utils.c @@ -250,9 +250,8 @@ ot_gio_splice_get_checksum (GOutputStream *out, guint8 digest[_OSTREE_SHA256_DIGEST_LEN]; ot_checksum_get_digest (&checksum, digest, sizeof (digest)); - g_autofree guchar *ret_csum = g_malloc (sizeof (digest)); - memcpy (ret_csum, digest, sizeof (digest)); - ot_transfer_out_value (out_csum, &ret_csum); + if (out_csum) + *out_csum = g_memdup (digest, sizeof (digest)); return TRUE; }