Javier Martinez Canillas
985a141002
Since Fedora 30 grub2 has support to populate its menu entries from the BootLoaderSpec fragments in /boot/loader/entries, so there's no need to generate menu entries anymore using the /etc/grub.d/15_ostree script. But since ostree doesn't update the bootloader, it may be that the grub2 installed is an old one that doesn't have BLS support. For new installs, GRUB_ENABLE_BLSCFG=true is set in /etc/default/grub to tell the /etc/grub.d/10_linux script if a blscfg command has to be added to the generated grub2 config file. So check if BLS is enabled in /etc/default/grub and only add the entries if that's not the case. Otherwise the menu entries will be duplicated. The approach has the drawback that if a user sets GRUB_ENABLE_BLSCFG=true in /etc/default/grub without updating grub2, they will get an empty menu. Since there won't be any entries created by the 30_ostree script and the blscfg command won't work on the older grub2. Unfortunately there is no way to know if the installed grub2 already has BLS support or not. Related: https://bugzilla.redhat.com/show_bug.cgi?id=1751272#c27 Closes: #1929 Approved by: jlebon
59 lines
1.9 KiB
Bash
59 lines
1.9 KiB
Bash
#!/bin/sh
|
|
#
|
|
# Copyright (C) 2014 Colin Walters <walters@verbum.org>
|
|
#
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU Lesser General Public License as published
|
|
# by the Free Software Foundation; either version 2 of the licence or (at
|
|
# your option) any later version.
|
|
#
|
|
# This library is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
# Lesser General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU Lesser General
|
|
# Public License along with this library; if not, write to the
|
|
# Free Software Foundation, Inc., 59 Temple Place, Suite 330,
|
|
# Boston, MA 02111-1307, USA.
|
|
|
|
# Gracefully exit if ostree is not installed, or there's
|
|
# no system repository initialized.
|
|
if ! which ostree >/dev/null 2>/dev/null; then
|
|
exit 0
|
|
fi
|
|
if ! test -d /ostree/repo; then
|
|
exit 0
|
|
fi
|
|
|
|
# Gracefully exit if the grub2 configuration has BLS enabled,
|
|
# since there is no need to create menu entries in that case.
|
|
. /etc/default/grub
|
|
if test ${GRUB_ENABLE_BLSCFG} = "true"; then
|
|
exit 0
|
|
fi
|
|
|
|
# Make sure we're in the right environment
|
|
if ! test -n "${GRUB_DEVICE}"; then
|
|
echo "This script must be run as a child of grub2-mkconfig" 1>&2
|
|
exit 1
|
|
fi
|
|
|
|
set -e
|
|
|
|
# Pick up stuff from grub's helper that we want to inject into our
|
|
# generated bootloader configuration. Yes, this is pretty awful, but
|
|
# it's a lot better than reimplementing the config-generating bits of
|
|
# OSTree in shell script.
|
|
|
|
. /usr/share/grub/grub-mkconfig_lib
|
|
|
|
DEVICE=${GRUB_DEVICE_BOOT:-${GRUB_DEVICE}}
|
|
|
|
GRUB2_BOOT_DEVICE_ID="$(grub_get_device_id ${DEVICE})"
|
|
export GRUB2_BOOT_DEVICE_ID
|
|
GRUB2_PREPARE_ROOT_CACHE="$(prepare_grub_to_access_device ${DEVICE})"
|
|
export GRUB2_PREPARE_ROOT_CACHE
|
|
|
|
exec ostree admin instutil grub2-generate
|