Colin Walters
7c8ea25306
lib/repo: Add a DEVINO_CANONICAL commit modifier flag
...
I was seeing the `Writing OSTree commit...` phase of rpm-ostree
being very slow lately. This turns out to be more fallout from
https://github.com/ostreedev/ostree/pull/1170
AKA commit: 8fe4536
Loading the xattrs is slow on my system (F27AW, XFS+LVM, NVMe). I haven't fully
traced through why, but AIUI at least on XFS the xattrs are often stored outside
of the inode so it's a little bit like doing an `open()+read()`. Plus there's
the LSM overhead, etc.
The thing is that for rpm-ostree's package layering use case, we
basically always want to treat the on-disk state as canonical. (There's
a subtle case here if one does overrides for something that contains
policy but we'll fix that).
Anyways, so we're in a state now where we do the slow but correct thing by
default, which seems sane. But let's allow the app to opt-in to telling us
"really trust devino". The difference between a `stat()` + hash table lookup
versus the full xattr load on my test case of `rpm-ostree install
./tree-1.7.0-10.fc27.x86_64.rpm` is absolutely dramatic; consistently on the
order of 10s without this support, and <1s with (800ms).
Closes : #1357
Approved by: jlebon
2017-12-04 14:42:37 +00:00
..
2017-03-30 19:19:54 +00:00
2015-03-19 12:43:04 -04:00
2016-03-03 08:50:19 -05:00
2017-10-23 17:02:28 +00:00
2017-09-27 14:44:00 +00:00
2017-10-23 14:19:41 +00:00
2017-03-24 22:16:43 +00:00
2017-10-20 13:20:27 +00:00
2016-04-04 14:19:35 +00:00
2017-03-30 19:19:54 +00:00
2017-09-15 18:51:43 +00:00
2017-11-01 17:38:26 +00:00
2017-11-01 17:38:26 +00:00
2016-07-28 10:10:17 +00:00
2015-05-28 14:21:30 -04:00
2017-10-16 13:08:06 +00:00
2017-09-30 00:05:07 +00:00
2017-09-19 15:16:09 +00:00
2017-11-01 17:38:26 +00:00
2016-04-04 14:19:35 +00:00
2016-06-09 21:10:35 +00:00
2016-02-26 08:19:01 -05:00
2016-02-26 08:19:01 -05:00
2017-11-01 17:38:26 +00:00
2017-11-06 19:41:07 +00:00
2017-09-21 21:38:34 +00:00
2017-09-27 14:44:00 +00:00
2017-09-01 20:54:12 +00:00
2017-09-01 20:54:12 +00:00
2017-09-01 20:54:12 +00:00
2017-09-01 20:54:12 +00:00
2017-09-01 20:54:12 +00:00
2017-09-01 20:54:12 +00:00
2017-09-01 20:54:12 +00:00
2017-09-01 20:54:12 +00:00
2017-10-23 14:19:41 +00:00
2017-09-01 20:54:12 +00:00
2017-09-01 20:54:12 +00:00
2017-09-01 20:54:12 +00:00
2017-09-01 20:54:12 +00:00
2017-09-01 20:54:12 +00:00
2017-09-01 20:54:12 +00:00
2017-09-01 20:54:12 +00:00
2017-09-01 20:54:12 +00:00
2016-06-27 20:20:21 +00:00
2017-09-30 00:05:07 +00:00
2017-04-25 13:52:35 +00:00
2017-09-27 13:13:14 +00:00
2017-12-04 14:42:37 +00:00
2017-09-27 13:13:14 +00:00
2017-09-21 21:38:34 +00:00
2017-09-21 21:38:34 +00:00
2017-09-21 21:38:34 +00:00
2017-09-27 19:04:11 +00:00
2017-07-21 15:45:27 +00:00
2017-05-09 14:05:46 +00:00
2017-09-27 14:44:00 +00:00
2017-09-01 20:54:12 +00:00
2017-09-01 20:54:12 +00:00
2017-09-01 20:54:12 +00:00
2017-08-24 19:57:33 +00:00
2017-06-26 15:56:07 +00:00
2017-09-01 20:54:12 +00:00
2017-09-21 21:38:34 +00:00
2017-10-20 12:59:32 +00:00
2017-06-26 15:56:07 +00:00
2017-09-21 21:38:34 +00:00
2017-09-21 21:38:34 +00:00
2017-08-30 14:30:30 +00:00
2017-09-01 20:54:12 +00:00
2017-09-01 20:54:12 +00:00
2017-09-21 21:38:34 +00:00
2017-09-21 21:38:34 +00:00
2017-09-21 21:38:34 +00:00
2017-09-21 21:38:34 +00:00
2017-09-01 20:54:12 +00:00
2017-09-21 21:38:34 +00:00
2017-09-21 21:38:34 +00:00
2017-09-21 21:38:34 +00:00
2017-09-01 20:54:12 +00:00
2017-06-26 15:56:07 +00:00
2017-09-18 17:20:38 +00:00
2017-11-01 17:38:26 +00:00
2017-07-10 14:18:18 +00:00
2017-08-29 19:08:59 +00:00
2017-10-17 15:20:08 +00:00
2017-09-21 21:38:34 +00:00
2017-07-06 19:08:14 +00:00
2017-09-01 20:54:12 +00:00
2017-09-01 20:54:12 +00:00
2017-10-17 05:06:07 +00:00
2017-09-01 20:54:12 +00:00
2017-09-01 20:54:12 +00:00
2017-08-14 12:04:42 +00:00
2017-09-01 20:54:12 +00:00
2017-09-01 20:54:12 +00:00
2017-11-27 22:31:22 +00:00
2017-09-01 20:54:12 +00:00
2017-09-01 20:54:12 +00:00
2017-09-01 20:54:12 +00:00
2017-09-01 20:54:12 +00:00
2017-09-01 20:54:12 +00:00
2017-03-24 22:16:43 +00:00
2017-09-07 18:49:55 +00:00
2017-10-18 20:55:43 +00:00
2017-06-26 15:56:07 +00:00
2016-03-03 08:50:19 -05:00
2017-09-01 20:54:12 +00:00
2017-09-01 20:54:12 +00:00
2017-05-18 01:14:15 +00:00
2017-09-13 16:03:25 +00:00
2017-09-21 21:38:34 +00:00
2017-11-28 18:53:25 +00:00
2017-09-28 14:08:40 +00:00
2017-10-11 19:26:10 +00:00
2017-09-28 14:08:40 +00:00
2017-09-01 20:54:12 +00:00
2017-09-21 16:51:15 +00:00
2017-09-21 21:38:34 +00:00
2017-09-21 21:38:34 +00:00
2017-07-21 15:45:27 +00:00
2017-08-24 19:57:33 +00:00
2017-10-02 13:39:41 +00:00
2017-11-09 17:15:59 +00:00
2017-06-27 21:45:34 +00:00
2017-11-02 13:53:41 +00:00
2017-09-21 21:38:34 +00:00
2017-09-15 18:51:43 +00:00
2017-09-21 21:38:34 +00:00
2017-09-01 20:54:12 +00:00