963395217a
We want a case where we can disable the min-free-space check. Initially, it felt like to add a OSTREE_REPO_PULL_FLAGS_DISABLE_FREE_SPACE_CHECK but the problem is prepare_transaction() does not have a OstreeRepoPullFlags parameter which we can parse right here. On top of it, prepare_transaction() enforces min-free-space check and won't let the transaction proceed if the check failed. This is pretty bad in conjunction with "inherit-transaction" as what Flatpak uses. There is no way to disable this check unless we remove it altogether from prepare_transaction. This issue came out to light when flatpak wasn't able to write metadata after fetching from remote: [uajain@localhost ~]$ flatpak remote-info flathub org.kde.Platform//5.9 error: min-free-space-size 500MB would be exceeded Metadata objects helps in housekeeping and restricting them means restricting crucial UX (like search, new updates) functionalities in clients like gnome-software. The error banners originated from these issues are also abrupt and not much helpful to the user. This is the specific instance of the issue this patches tries to address. See https://github.com/flatpak/flatpak/issues/2139 for discussion. Closes: #1779 Approved by: mwleeds |
||
|---|---|---|
| .. | ||
| itest-bare-unit.sh | ||
| itest-bare-user-root.sh | ||
| itest-bareuser-nouserxattrs.sh | ||
| itest-payload-link.sh | ||
| itest-pull-space.sh | ||
| itest-pull.sh | ||
| itest-remotes.sh | ||
| libtest-core.sh | ||