packaging
/
ostree
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

repo: Drop the branch parameter from ostree_repo_commit 

It's unused. Make users explicitly write a ref if they want this;
high-level convenience API will be introduced later.

https://bugzilla.gnome.org/show_bug.cgi?id=707727
This commit is contained in:
Jasper St. Pierre 2013-09-06 20:09:44 -04:00
parent f49ed9e74d
commit 1f8db2a873
3 changed files with 10 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/libostree/ostree-repo-commit.c
View File

@ -1190,7 +1190,6 @@ create_empty_gvariant_dict (void)
/**
* ostree_repo_write_commit:
* @self: Repo
* @branch: Name of ref
* @parent: (allow-none): ASCII SHA256 checksum for parent, or %NULL for none
* @subject: Subject
* @body: Body
@ -1204,16 +1203,15 @@ create_empty_gvariant_dict (void)
* and @root_metadata_checksum.
*/
gboolean
ostree_repo_write_commit (OstreeRepo *self,
const char *branch,
const char *parent,
const char *subject,
const char *body,
const char *root_contents_checksum,
const char *root_metadata_checksum,
char **out_commit,
GCancellable *cancellable,
GError **error)
ostree_repo_write_commit (OstreeRepo *self,
const char *parent,
const char *subject,
const char *body,
const char *root_contents_checksum,
const char *root_metadata_checksum,
char **out_commit,
GCancellable *cancellable,
GError **error)
{
gboolean ret = FALSE;
gs_free char *ret_commit = NULL;
@ -1221,7 +1219,6 @@ ostree_repo_write_commit (OstreeRepo *self,
gs_free guchar *commit_csum = NULL;
GDateTime *now = NULL;
g_return_val_if_fail (branch != NULL, FALSE);
g_return_val_if_fail (subject != NULL, FALSE);
g_return_val_if_fail (root_contents_checksum != NULL, FALSE);
g_return_val_if_fail (root_metadata_checksum != NULL, FALSE);

1
src/libostree/ostree-repo.h
View File

@ -315,7 +315,6 @@ gboolean ostree_repo_write_mtree (OstreeRepo *self,
GError **error);
gboolean ostree_repo_write_commit (OstreeRepo *self,
const char *branch,
const char *parent,
const char *subject,
const char *body,

2
src/ostree/ot-builtin-commit.c
View File

@ -404,7 +404,7 @@ ostree_builtin_commit (int argc, char **argv, OstreeRepo *repo, GCancellable *ca
goto out;
}
if (!ostree_repo_write_commit (repo, opt_branch, parent, opt_subject, opt_body,
if (!ostree_repo_write_commit (repo, parent, opt_subject, opt_body,
contents_checksum, root_metadata,
&commit_checksum, cancellable, error))
goto out;