packaging
/
ostree
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tests/keyfile-utils: Drop tests covering preconditions 

The spam in stderr was bothering me, and further at some eventual
point in the future we want to annotate the functions with
`__attribute__((nonnull))` which would then cause tests like these to
become undefined behavior.

The coverage of this isn't worth the log spam basically.

Closes: #611
Approved by: jlebon
This commit is contained in:
Colin Walters 2016-12-05 13:08:39 -05:00 committed by Atomic Bot
parent 555f1fb03d
commit 66da1199f0
1 changed files with 0 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
tests/test-keyfile-utils.c
View File

@ -34,37 +34,6 @@ test_get_boolean_with_default (void)
g_autoptr(GError) error = NULL; g_autoptr(GError) error = NULL;
gboolean out = FALSE; gboolean out = FALSE;
GLogLevelFlags always_fatal_mask;
/* Avoid that g_return_val_if_fail causes the test to fail. */
always_fatal_mask = g_log_set_always_fatal (0);
g_assert_false (ot_keyfile_get_boolean_with_default (NULL,
"section",
"a_boolean_true",
FALSE,
&out,
&error));
g_clear_error (&error);
g_assert_false (ot_keyfile_get_boolean_with_default (g_keyfile,
NULL,
"a_boolean_true",
FALSE,
&out,
&error));
g_clear_error (&error);
g_assert_false (ot_keyfile_get_boolean_with_default (g_keyfile,
"section",
NULL,
FALSE,
&out,
&error));
g_clear_error (&error);
/* Restore the old mask. */
g_log_set_always_fatal (always_fatal_mask);
g_assert (ot_keyfile_get_boolean_with_default (g_keyfile, g_assert (ot_keyfile_get_boolean_with_default (g_keyfile,
"section", "section",
"a_boolean_true", "a_boolean_true",